Skip to content

Include alias type arguments in keys for aliased types#42365

Merged
ahejlsberg merged 1 commit intomasterfrom
fix42317
Jan 16, 2021
Merged

Include alias type arguments in keys for aliased types#42365
ahejlsberg merged 1 commit intomasterfrom
fix42317

Conversation

@ahejlsberg
Copy link
Member

@ahejlsberg ahejlsberg commented Jan 15, 2021

Fixes #42317.

@typescript-bot typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Jan 15, 2021
@ahejlsberg
Copy link
Member Author

ahejlsberg commented Jan 15, 2021

@typescript-bot test this
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this faster

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 15, 2021 •
edited
Loading

Heya @ahejlsberg, I've started to run the extended test suite on this PR at efd7bc9. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 15, 2021 •
edited
Loading

Heya @ahejlsberg, I've started to run the parallelized community code test suite on this PR at efd7bc9. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 15, 2021 •
edited
Loading

Heya @ahejlsberg, I've started to run the abridged perf test suite on this PR at efd7bc9. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 15, 2021 •
edited
Loading

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at efd7bc9. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 15, 2021

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..42365

Metric master 42365 Delta Best Worst
Angular - node (v14.15.1, x64)
Memory used 322,723k (± 0.01%) 322,699k (± 0.01%) -24k (- 0.01%) 322,630k 322,751k
Parse Time 2.00s (± 0.47%) 2.01s (± 0.53%) +0.01s (+ 0.45%) 1.99s 2.03s
Bind Time 0.85s (± 0.35%) 0.85s (± 0.39%) -0.00s (- 0.23%) 0.84s 0.86s
Check Time 4.89s (± 0.33%) 4.90s (± 0.34%) +0.02s (+ 0.35%) 4.87s 4.95s
Emit Time 5.52s (± 0.25%) 5.55s (± 0.76%) +0.02s (+ 0.42%) 5.48s 5.67s
Total Time 13.26s (± 0.22%) 13.31s (± 0.33%) +0.05s (+ 0.35%) 13.23s 13.44s
Compiler-Unions - node (v14.15.1, x64)
Memory used 201,679k (± 0.53%) 200,445k (± 0.37%) -1,234k (- 0.61%) 199,610k 203,371k
Parse Time 0.82s (± 0.60%) 0.82s (± 0.46%) -0.00s (- 0.12%) 0.81s 0.82s
Bind Time 0.53s (± 0.84%) 0.53s (± 0.65%) -0.01s (- 0.94%) 0.52s 0.53s
Check Time 9.75s (± 0.94%) 9.86s (± 1.00%) +0.11s (+ 1.11%) 9.65s 10.07s
Emit Time 2.35s (± 1.56%) 2.32s (± 0.89%) -0.03s (- 1.11%) 2.29s 2.37s
Total Time 13.45s (± 0.68%) 13.53s (± 0.75%) +0.07s (+ 0.52%) 13.30s 13.69s
Monaco - node (v14.15.1, x64)
Memory used 336,819k (± 0.01%) 336,812k (± 0.01%) -7k (- 0.00%) 336,730k 336,876k
Parse Time 1.65s (± 0.64%) 1.64s (± 0.67%) -0.01s (- 0.61%) 1.62s 1.66s
Bind Time 0.73s (± 0.91%) 0.73s (± 0.79%) +0.00s (+ 0.00%) 0.72s 0.75s
Check Time 4.84s (± 0.46%) 4.86s (± 0.37%) +0.02s (+ 0.39%) 4.82s 4.91s
Emit Time 2.94s (± 0.65%) 2.93s (± 0.69%) -0.01s (- 0.34%) 2.88s 2.97s
Total Time 10.15s (± 0.34%) 10.16s (± 0.33%) +0.00s (+ 0.01%) 10.09s 10.23s
TFS - node (v14.15.1, x64)
Memory used 291,598k (± 0.00%) 291,585k (± 0.01%) -13k (- 0.00%) 291,531k 291,625k
Parse Time 1.30s (± 0.70%) 1.31s (± 1.37%) +0.01s (+ 0.46%) 1.27s 1.35s
Bind Time 0.69s (± 0.43%) 0.69s (± 1.16%) -0.00s (- 0.58%) 0.67s 0.71s
Check Time 4.48s (± 0.53%) 4.49s (± 0.65%) +0.01s (+ 0.27%) 4.44s 4.54s
Emit Time 3.06s (± 0.73%) 3.05s (± 0.50%) -0.01s (- 0.26%) 3.03s 3.10s
Total Time 9.53s (± 0.37%) 9.54s (± 0.48%) +0.01s (+ 0.10%) 9.44s 9.64s
material-ui - node (v14.15.1, x64)
Memory used 472,109k (± 0.05%) 472,518k (± 0.04%) +409k (+ 0.09%) 472,024k 472,738k
Parse Time 2.13s (± 0.61%) 2.14s (± 0.48%) +0.01s (+ 0.61%) 2.12s 2.17s
Bind Time 0.69s (± 0.90%) 0.69s (± 0.68%) +0.00s (+ 0.15%) 0.68s 0.70s
Check Time 12.69s (± 0.95%) 12.69s (± 0.81%) -0.01s (- 0.06%) 12.50s 12.96s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.51s (± 0.72%) 15.52s (± 0.63%) +0.01s (+ 0.06%) 15.34s 15.78s
System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-198-generic
Architecturex64
Available Memory16 GB
Available Memory10 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v14.15.1, x64)
Benchmark Name Iterations
Current 42365 10
Baseline master 10

@typescript-bot typescript-bot mentioned this pull request Jan 15, 2021
Open
@typescript-bot
Copy link
Collaborator

typescript-bot commented Jan 15, 2021

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

@ahejlsberg ahejlsberg merged commit 70c82ca into master Jan 16, 2021
@ahejlsberg ahejlsberg deleted the fix42317 branch January 16, 2021 02:01
@Andarist Andarist mentioned this pull request Mar 30, 2025
Merged
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sandersn sandersn sandersn approved these changes

@DanielRosenwasser DanielRosenwasser DanielRosenwasser approved these changes

Assignees

@ahejlsberg ahejlsberg

Labels

Author: Team For Milestone Bug PRs that fix a bug with a specific milestone

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

jquery has batch-only inference error after re-aliasing support (##42284)

4 participants

@ahejlsberg @typescript-bot @sandersn @DanielRosenwasser