Fix nested package json lookup in modes that respect package.json exports#51995
Merged
andrewbranch merged 1 commit intomicrosoft:mainfrom Jan 11, 2023
Merged
Conversation
sandersn
approved these changes
Jan 9, 2023
| return withPackageId(packageInfo, fromDirectory); | ||
| if (rest !== "" && packageInfo && ( | ||
| !(state.features & NodeResolutionFeatures.Exports) || | ||
| !hasProperty((rootPackageInfo = getPackageJsonInfo(packageDirectory, !nodeModulesDirectoryExists, state))?.contents.packageJsonContent ?? emptyArray, "exports") |
Member
There was a problem hiding this comment.
I assume that non-embedded assignment is many more lines of code, but .. that assignment is really easy to miss.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue noticed in #51973
I spent the better part of two days trying to rewrite
loadModuleFromSpecificNodeModulesDirectoryandloadNodeModuleFromDirectoryWorker. I noticed some other bugs buried in them, and they have a bunch of duplication between them and are incredibly hard to follow. In the end I decided to just try to fix this bug as narrowly as possible first, as I was afraid a bigger refactoring would surface other bugs I wouldn’t have time to fix before the 5.0 RC.