Support custom 'Symbol.hasInstance' methods when narrowing 'instanceof' by rbuckton · Pull Request #55052 · microsoft/TypeScript

rbuckton · 2023-07-17T18:10:43Z

This makes our instanceof narrowing more closely align to Steps 2-3 of the InstanceofOperator algorithm in the ECMA-262 specification by allowing any object type in the right-hand side of instanceof as long as it has a valid [Symbol.hasInstance] method. If such a method exists and returns a type predicate, that predicate can then be used when narrowing instanceof.

interface Point { x: number, y: number };

const Point = {
  create(x: number, y: number): Point {
    return { x, y };
  },
  [Symbol.hasInstance](value: unknown): value is Point {
    return typeof value === "object" && value !== null &&
      "x" in value && typeof (value as Point).x === "number" &&
      "y" in value && typeof (value as Point).y === "number";
  }
};

interface Line { ... }

declare const p: Point | Line;
if (p instanceof Point) {
  p; // Point
} else {
  p; // Line
}

For a [Symbol.hasInstance] method to be considered during instanceof narrowing, it must have a type predicate as its return type.

In addition, when the left-hand side of instanceof is considered as an argument to [Symbol.hasInstance], it must be assignable to the first parameter. This does not, however, weaken our current requirement that the left-hand side be an object type (or a union containing an object type), despite the fact this is not currently a requirement of ECMAScript.

This is intended to address rather complicated workarounds employed by, for example, engine262 which uses [Symbol.hasInstance] as a runtime type guard, but needed to introduce a non-creatable abstract class so that TypeScript would understand the type guard: https://github.com/engine262/engine262/blob/435e533f8bb2f66961e3c16fe67150a0bba745bb/src/completion.mts#L70

Fixes #17360
Fixes #39064
Related #32080
Related #52670

NOTE: This will need to wait for 5.3 at the earliest.

…wing 'instanceof'

typescript-bot · 2023-07-17T22:05:06Z

Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page.

Also, please make sure @DanielRosenwasser and @RyanCavanaugh are aware of the changes, just as a heads up.

gabritto · 2023-07-18T19:32:44Z

@typescript-bot pack this

typescript-bot · 2023-07-18T19:32:46Z

Heya @gabritto, I've started to run the tarball bundle task on this PR at 6a4f838. You can monitor the build here.

typescript-bot · 2023-07-18T19:34:55Z

Hey @gabritto, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/155911/artifacts?artifactName=tgz&fileId=97BAAB5AACB42F8DDA14CB27D0D6B4CD5415D110CC5CD3B416AD60372D09BDEC02&fileName=/typescript-5.2.0-insiders.20230718.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.2.0-pr-55052-3".;

src/compiler/checker.ts

rbuckton · 2023-07-18T20:23:17Z

@typescript-bot perf test
@typescript-bot run dt
@typescript-bot test this
@typescript-bot user test this

typescript-bot · 2023-07-18T20:23:19Z

Heya @rbuckton, I've started to run the diff-based user code test suite on this PR at 6a4f838. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-07-18T20:23:19Z

Heya @rbuckton, I've started to run the perf test suite on this PR at 6a4f838. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-07-18T20:23:19Z

Heya @rbuckton, I've started to run the extended test suite on this PR at 6a4f838. You can monitor the build here.

typescript-bot · 2023-07-18T20:23:20Z

Heya @rbuckton, I've started to run the parallelized Definitely Typed test suite on this PR at 6a4f838. You can monitor the build here.

Update: The results are in!

typescript-bot · 2023-07-18T20:50:54Z

@rbuckton Here are the results of running the user test suite comparing main and refs/pull/55052/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Unknown failure"
1 instance of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

rxjs-src

/mnt/ts_downloads/rxjs-src/build.sh

[NEW] error TS2428: All declarations of 'WeakMap' must have identical type parameters.
- /home/vsts/work/1/s/typescript-55052/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-55052/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-55052/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-55052/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-55052/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-55052/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-55052/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-55052/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-55052/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-55052/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-55052/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-55052/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-55052/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-55052/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-55052/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
[MISSING] error TS2428: All declarations of 'WeakMap' must have identical type parameters.
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.collection.d.ts(63,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.iterable.d.ts(162,11)
- /home/vsts/work/1/s/typescript-main/lib/lib.es2015.symbol.wellknown.d.ts(140,11)

typescript-bot · 2023-07-18T21:19:48Z

@rbuckton
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..55052

_Metric	_main	₅₅₀₅₂	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.10.0, x64)}
_{Memory used}	_{366,844k (± 0.01%)}	_{366,878k (± 0.01%)}	_~	_366,829k	_366,937k	_{p=0.093 n=6}
_{Parse Time}	_{3.38s (± 0.46%)}	_{3.40s (± 1.11%)}	_~	_3.35s	_3.46s	_{p=0.294 n=6}
_{Bind Time}	_{1.12s (± 0.56%)}	_{1.12s (± 0.67%)}	_~	_1.11s	_1.13s	_{p=0.718 n=6}
_{Check Time}	_{8.91s (± 0.42%)}	_{8.90s (± 0.66%)}	_~	_8.82s	_8.99s	_{p=0.748 n=6}
_{Emit Time}	_{7.52s (± 1.00%)}	_{7.54s (± 0.74%)}	_~	_7.48s	_7.61s	_{p=0.423 n=6}
_{Total Time}	_{20.94s (± 0.46%)}	_{20.96s (± 0.54%)}	_~	_20.79s	_21.08s	_{p=0.688 n=6}
_{Compiler-Unions - node (v18.10.0, x64)}
_{Memory used}	_{192,067k (± 1.18%)}	_{191,106k (± 0.04%)}	_~	_191,030k	_191,204k	_{p=0.378 n=6}
_{Parse Time}	_{1.50s (± 0.54%)}	_{1.52s (± 0.68%)}	_{+0.01s (+ 0.89%)}	_1.50s	_1.53s	_{p=0.047 n=6}
_{Bind Time}	_{0.77s (± 0.53%)}	_{0.77s (± 0.53%)}	_~	_0.77s	_0.78s	_{p=1.000 n=6}
_{Check Time}	_{9.52s (± 0.93%)}	_{9.51s (± 0.41%)}	_~	_9.46s	_9.57s	_{p=0.227 n=6}
_{Emit Time}	_{2.74s (± 1.02%)}	_{2.77s (± 1.77%)}	_~	_2.70s	_2.84s	_{p=0.332 n=6}
_{Total Time}	_{14.54s (± 0.69%)}	_{14.56s (± 0.48%)}	_~	_14.48s	_14.66s	_{p=1.000 n=6}
_{Monaco - node (v18.10.0, x64)}
_{Memory used}	_{346,870k (± 0.01%)}	_{346,895k (± 0.01%)}	_~	_346,864k	_346,932k	_{p=0.148 n=6}
_{Parse Time}	_{2.62s (± 0.61%)}	_{2.64s (± 0.89%)}	_~	_2.60s	_2.67s	_{p=0.315 n=6}
_{Bind Time}	_{1.01s (± 0.40%)}	_{1.01s (± 1.19%)}	_~	_1.00s	_1.03s	_{p=0.863 n=6}
_{Check Time}	_{7.29s (± 0.42%)}	_{7.32s (± 0.22%)}	_~	_7.29s	_7.34s	_{p=0.106 n=6}
_{Emit Time}	_{4.28s (± 0.43%)}	_{4.25s (± 0.61%)}	_~	_4.22s	_4.29s	_{p=0.064 n=6}
_{Total Time}	_{15.21s (± 0.16%)}	_{15.22s (± 0.31%)}	_~	_15.17s	_15.30s	_{p=1.000 n=6}
_{TFS - node (v18.10.0, x64)}
_{Memory used}	_{300,910k (± 0.00%)}	_{300,938k (± 0.01%)}	_{+28k (+ 0.01%)}	_300,917k	_300,956k	_{p=0.020 n=6}
_{Parse Time}	_{2.09s (± 1.02%)}	_{2.08s (± 0.72%)}	_~	_2.07s	_2.11s	_{p=0.465 n=6}
_{Bind Time}	_{1.13s (± 0.46%)}	_{1.13s (± 0.56%)}	_~	_1.12s	_1.14s	_{p=0.386 n=6}
_{Check Time}	_{6.66s (± 0.57%)}	_{6.69s (± 0.44%)}	_~	_6.65s	_6.74s	_{p=0.106 n=6}
_{Emit Time}	_{3.88s (± 0.51%)}	_{3.88s (± 0.93%)}	_~	_3.83s	_3.94s	_{p=0.624 n=6}
_{Total Time}	_{13.74s (± 0.28%)}	_{13.79s (± 0.50%)}	_~	_13.68s	_13.88s	_{p=0.227 n=6}
_{material-ui - node (v18.10.0, x64)}
_{Memory used}	_{482,367k (± 0.01%)}	_{482,395k (± 0.01%)}	_~	_482,341k	_482,452k	_{p=0.471 n=6}
_{Parse Time}	_{3.02s (± 2.11%)}	_{3.10s (± 2.15%)}	_~	_2.97s	_3.14s	_{p=0.065 n=6}
_{Bind Time}	_{0.97s (± 5.46%)}	_{0.94s (± 3.89%)}	_~	_0.91s	_1.01s	_{p=0.293 n=6}
_{Check Time}	_{17.38s (± 0.78%)}	_{17.32s (± 0.50%)}	_~	_17.23s	_17.45s	_{p=0.378 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{21.37s (± 0.68%)}	_{21.35s (± 0.46%)}	_~	_21.27s	_21.51s	_{p=0.687 n=6}
_{xstate - node (v18.10.0, x64)}
_{Memory used}	_{563,592k (± 0.01%)}	_{563,667k (± 0.03%)}	_~	_563,503k	_563,862k	_{p=0.810 n=6}
_{Parse Time}	_{3.84s (± 0.69%)}	_{3.86s (± 0.45%)}	_~	_3.83s	_3.87s	_{p=0.224 n=6}
_{Bind Time}	_{1.66s (± 0.25%)}	_{1.66s (± 1.12%)}	_~	_1.63s	_1.68s	_{p=0.245 n=6}
_{Check Time}	_{2.81s (± 0.49%)}	_{2.80s (± 0.65%)}	_~	_2.78s	_2.83s	_{p=0.681 n=6}
_{Emit Time}	_{0.08s (± 0.00%)}	_{0.08s (± 0.00%)}	_~	_0.08s	_0.08s	_{p=1.000 n=6}
_{Total Time}	_{8.39s (± 0.34%)}	_{8.40s (± 0.30%)}	_~	_8.36s	_8.43s	_{p=0.466 n=6}
_{Angular - node (v16.17.1, x64)}
_{Memory used}	_{366,223k (± 0.01%)}	_{366,269k (± 0.01%)}	_{+46k (+ 0.01%)}	_366,228k	_366,289k	_{p=0.020 n=6}
_{Parse Time}	_{3.56s (± 0.65%)}	_{3.57s (± 0.79%)}	_~	_3.54s	_3.61s	_{p=0.686 n=6}
_{Bind Time}	_{1.19s (± 0.63%)}	_{1.19s (± 0.34%)}	_~	_1.19s	_1.20s	_{p=0.389 n=6}
_{Check Time}	_{9.71s (± 0.46%)}	_{9.66s (± 0.32%)}	_~	_9.60s	_9.68s	_{p=0.123 n=6}
_{Emit Time}	_{8.09s (± 0.46%)}	_{7.99s (± 0.42%)}	_{-0.09s (- 1.15%)}	_7.95s	_8.05s	_{p=0.008 n=6}
_{Total Time}	_{22.54s (± 0.28%)}	_{22.41s (± 0.33%)}	_{-0.13s (- 0.57%)}	_22.33s	_22.53s	_{p=0.020 n=6}
_{Compiler-Unions - node (v16.17.1, x64)}
_{Memory used}	_{193,442k (± 0.68%)}	_{192,872k (± 0.02%)}	_~	_192,822k	_192,950k	_{p=0.149 n=6}
_{Parse Time}	_{1.59s (± 0.51%)}	_{1.60s (± 0.51%)}	_~	_1.59s	_1.61s	_{p=0.666 n=6}
_{Bind Time}	_{0.83s (± 0.66%)}	_{0.83s (± 0.99%)}	_~	_0.82s	_0.84s	_{p=0.859 n=6}
_{Check Time}	_{10.15s (± 0.76%)}	_{10.14s (± 0.27%)}	_~	_10.11s	_10.18s	_{p=0.936 n=6}
_{Emit Time}	_{3.00s (± 0.53%)}	_{3.02s (± 0.90%)}	_~	_2.98s	_3.05s	_{p=0.195 n=6}
_{Total Time}	_{15.56s (± 0.54%)}	_{15.59s (± 0.33%)}	_~	_15.52s	_15.65s	_{p=0.517 n=6}
_{Monaco - node (v16.17.1, x64)}
_{Memory used}	_{346,183k (± 0.01%)}	_{346,203k (± 0.01%)}	_~	_346,164k	_346,232k	_{p=0.173 n=6}
_{Parse Time}	_{2.77s (± 0.49%)}	_{2.77s (± 0.53%)}	_~	_2.75s	_2.79s	_{p=0.934 n=6}
_{Bind Time}	_{1.07s (± 0.38%)}	_{1.08s (± 0.48%)}	_{+0.01s (+ 0.78%)}	_1.07s	_1.08s	_{p=0.022 n=6}
_{Check Time}	_{8.01s (± 0.67%)}	_{8.03s (± 0.29%)}	_~	_7.99s	_8.06s	_{p=0.872 n=6}
_{Emit Time}	_{4.49s (± 0.60%)}	_{4.48s (± 0.86%)}	_~	_4.41s	_4.52s	_{p=0.627 n=6}
_{Total Time}	_{16.34s (± 0.50%)}	_{16.35s (± 0.38%)}	_~	_16.28s	_16.45s	_{p=1.000 n=6}
_{TFS - node (v16.17.1, x64)}
_{Memory used}	_{300,246k (± 0.00%)}	_{300,268k (± 0.01%)}	_~	_300,240k	_300,291k	_{p=0.065 n=6}
_{Parse Time}	_{2.21s (± 0.62%)}	_{2.20s (± 0.89%)}	_~	_2.19s	_2.24s	_{p=0.739 n=6}
_{Bind Time}	_{1.20s (± 1.33%)}	_{1.22s (± 0.96%)}	_~	_1.21s	_1.24s	_{p=0.118 n=6}
_{Check Time}	_{7.33s (± 0.45%)}	_{7.33s (± 0.54%)}	_~	_7.27s	_7.37s	_{p=1.000 n=6}
_{Emit Time}	_{4.35s (± 0.52%)}	_{4.33s (± 0.81%)}	_~	_4.28s	_4.37s	_{p=0.324 n=6}
_{Total Time}	_{15.09s (± 0.33%)}	_{15.09s (± 0.57%)}	_~	_14.96s	_15.19s	_{p=1.000 n=6}
_{material-ui - node (v16.17.1, x64)}
_{Memory used}	_{481,657k (± 0.01%)}	_{481,664k (± 0.01%)}	_~	_481,607k	_481,762k	_{p=0.936 n=6}
_{Parse Time}	_{3.25s (± 0.41%)}	_{3.25s (± 0.37%)}	_~	_3.23s	_3.26s	_{p=0.490 n=6}
_{Bind Time}	_{0.96s (± 0.78%)}	_{0.96s (± 0.54%)}	_~	_0.95s	_0.96s	_{p=0.241 n=6}
_{Check Time}	_{18.45s (± 0.60%)}	_{18.29s (± 0.31%)}	_{-0.16s (- 0.89%)}	_18.22s	_18.34s	_{p=0.024 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{22.67s (± 0.46%)}	_{22.49s (± 0.26%)}	_{-0.18s (- 0.78%)}	_22.41s	_22.56s	_{p=0.020 n=6}
_{xstate - node (v16.17.1, x64)}
_{Memory used}	_{561,367k (± 0.03%)}	_{561,288k (± 0.03%)}	_~	_561,125k	_561,606k	_{p=0.378 n=6}
_{Parse Time}	_{4.00s (± 0.34%)}	_{4.01s (± 0.41%)}	_~	_3.99s	_4.03s	_{p=0.935 n=6}
_{Bind Time}	_{1.78s (± 1.05%)}	_{1.76s (± 1.33%)}	_~	_1.73s	_1.79s	_{p=0.513 n=6}
_{Check Time}	_{3.07s (± 0.39%)}	_{3.06s (± 0.49%)}	_~	_3.04s	_3.08s	_{p=0.742 n=6}
_{Emit Time}	_{0.10s (± 5.76%)}	_{0.09s (± 5.53%)}	_~	_0.09s	_0.10s	_{p=0.640 n=6}
_{Total Time}	_{8.94s (± 0.39%)}	_{8.92s (± 0.35%)}	_~	_8.89s	_8.97s	_{p=0.687 n=6}
_{Angular - node (v14.21.3, x64)}
_{Memory used}	_{360,186k (± 0.01%)}	_{360,212k (± 0.01%)}	_~	_360,179k	_360,272k	_{p=0.149 n=6}
_{Parse Time}	_{3.71s (± 0.15%)}	_{3.73s (± 0.36%)}	_{+0.02s (+ 0.45%)}	_3.71s	_3.75s	_{p=0.032 n=6}
_{Bind Time}	_{1.22s (± 0.62%)}	_{1.23s (± 0.66%)}	_~	_1.22s	_1.24s	_{p=0.120 n=6}
_{Check Time}	_{10.07s (± 0.38%)}	_{10.14s (± 0.35%)}	_{+0.07s (+ 0.66%)}	_10.09s	_10.18s	_{p=0.029 n=6}
_{Emit Time}	_{8.34s (± 0.74%)}	_{8.36s (± 0.39%)}	_~	_8.30s	_8.39s	_{p=0.520 n=6}
_{Total Time}	_{23.35s (± 0.36%)}	_{23.45s (± 0.24%)}	_~	_23.38s	_23.52s	_{p=0.054 n=6}
_{Compiler-Unions - node (v14.21.3, x64)}
_{Memory used}	_{188,193k (± 0.01%)}	_{188,197k (± 0.01%)}	_~	_188,159k	_188,239k	_{p=0.630 n=6}
_{Parse Time}	_{1.61s (± 0.61%)}	_{1.62s (± 1.03%)}	_~	_1.60s	_1.64s	_{p=0.209 n=6}
_{Bind Time}	_{0.85s (± 0.48%)}	_{0.85s (± 1.37%)}	_~	_0.84s	_0.87s	_{p=0.858 n=6}
_{Check Time}	_{10.30s (± 0.80%)}	_{10.33s (± 0.62%)}	_~	_10.24s	_10.43s	_{p=0.520 n=6}
_{Emit Time}	_{3.13s (± 0.92%)}	_{3.13s (± 1.29%)}	_~	_3.10s	_3.21s	_{p=0.802 n=6}
_{Total Time}	_{15.90s (± 0.51%)}	_{15.94s (± 0.53%)}	_~	_15.85s	_16.03s	_{p=0.294 n=6}
_{Monaco - node (v14.21.3, x64)}
_{Memory used}	_{341,176k (± 0.01%)}	_{341,205k (± 0.01%)}	_~	_341,170k	_341,249k	_{p=0.149 n=6}
_{Parse Time}	_{2.81s (± 0.49%)}	_{2.81s (± 0.55%)}	_~	_2.79s	_2.83s	_{p=0.805 n=6}
_{Bind Time}	_{1.09s (± 0.47%)}	_{1.10s (± 0.57%)}	_~	_1.09s	_1.11s	_{p=0.091 n=6}
_{Check Time}	_{8.27s (± 0.55%)}	_{8.31s (± 0.39%)}	_~	_8.27s	_8.35s	_{p=0.198 n=6}
_{Emit Time}	_{4.69s (± 0.65%)}	_{4.66s (± 0.43%)}	_~	_4.63s	_4.69s	_{p=0.107 n=6}
_{Total Time}	_{16.86s (± 0.40%)}	_{16.88s (± 0.28%)}	_~	_16.82s	_16.93s	_{p=0.572 n=6}
_{TFS - node (v14.21.3, x64)}
_{Memory used}	_{295,329k (± 0.00%)}	_{295,342k (± 0.00%)}	_{+14k (+ 0.00%)}	_295,336k	_295,347k	_{p=0.020 n=6}
_{Parse Time}	_{2.42s (± 1.25%)}	_{2.43s (± 0.60%)}	_~	_2.41s	_2.45s	_{p=0.145 n=6}
_{Bind Time}	_{1.08s (± 0.70%)}	_{1.08s (± 0.91%)}	_~	_1.07s	_1.09s	_{p=0.554 n=6}
_{Check Time}	_{7.65s (± 0.58%)}	_{7.66s (± 0.45%)}	_~	_7.63s	_7.72s	_{p=0.805 n=6}
_{Emit Time}	_{4.29s (± 0.67%)}	_{4.30s (± 0.77%)}	_~	_4.26s	_4.34s	_{p=0.687 n=6}
_{Total Time}	_{15.45s (± 0.41%)}	_{15.48s (± 0.28%)}	_~	_15.42s	_15.53s	_{p=0.574 n=6}
_{material-ui - node (v14.21.3, x64)}
_{Memory used}	_{477,159k (± 0.00%)}	_{477,170k (± 0.00%)}	_~	_477,156k	_477,191k	_{p=0.199 n=6}
_{Parse Time}	_{3.31s (± 0.63%)}	_{3.30s (± 0.56%)}	_~	_3.29s	_3.34s	_{p=0.677 n=6}
_{Bind Time}	_{0.99s (± 0.41%)}	_{0.99s (± 0.52%)}	_~	_0.99s	_1.00s	_{p=0.114 n=6}
_{Check Time}	_{19.21s (± 0.59%)}	_{19.16s (± 0.41%)}	_~	_19.09s	_19.31s	_{p=0.336 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{23.51s (± 0.48%)}	_{23.46s (± 0.37%)}	_~	_23.38s	_23.61s	_{p=0.423 n=6}
_{xstate - node (v14.21.3, x64)}
_{Memory used}	_{550,104k (± 0.00%)}	_{550,124k (± 0.01%)}	_~	_550,077k	_550,187k	_{p=0.689 n=6}
_{Parse Time}	_{4.21s (± 0.34%)}	_{4.22s (± 0.44%)}	_~	_4.20s	_4.24s	_{p=0.627 n=6}
_{Bind Time}	_{1.67s (± 2.16%)}	_{1.69s (± 0.58%)}	_~	_1.68s	_1.70s	_{p=0.625 n=6}
_{Check Time}	_{3.14s (± 0.44%)}	_{3.13s (± 0.49%)}	_{-0.01s (- 0.48%)}	_3.11s	_3.14s	_{p=0.034 n=6}
_{Emit Time}	_{0.09s (± 0.00%)}	_{0.09s (± 0.00%)}	_~	_0.09s	_0.09s	_{p=1.000 n=6}
_{Total Time}	_{9.12s (± 0.37%)}	_{9.13s (± 0.24%)}	_~	_9.10s	_9.16s	_{p=0.747 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-148-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v18.10.0, x64)
node (v16.17.1, x64)
node (v14.21.3, x64)

Scenarios

Angular - node (v18.10.0, x64)
Angular - node (v16.17.1, x64)
Angular - node (v14.21.3, x64)
Compiler-Unions - node (v18.10.0, x64)
Compiler-Unions - node (v16.17.1, x64)
Compiler-Unions - node (v14.21.3, x64)
Monaco - node (v18.10.0, x64)
Monaco - node (v16.17.1, x64)
Monaco - node (v14.21.3, x64)
TFS - node (v18.10.0, x64)
TFS - node (v16.17.1, x64)
TFS - node (v14.21.3, x64)
material-ui - node (v18.10.0, x64)
material-ui - node (v16.17.1, x64)
material-ui - node (v14.21.3, x64)
xstate - node (v18.10.0, x64)
xstate - node (v16.17.1, x64)
xstate - node (v14.21.3, x64)

_Benchmark	_Name	_Iterations
_Current	₅₅₀₅₂	₆
_Baseline	_main	₆

TSServer

Comparison Report - main..55052

_Metric	_main	₅₅₀₅₂	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{2,530ms (± 0.79%)}	_{2,564ms (± 0.61%)}	_{+34ms (+ 1.34%)}	_2,543ms	_2,589ms	_{p=0.013 n=6}
_{Req 2 - geterr}	_{5,382ms (± 0.69%)}	_{5,386ms (± 0.48%)}	_~	_5,340ms	_5,418ms	_{p=0.748 n=6}
_{Req 3 - references}	_{340ms (± 0.44%)}	_{342ms (± 0.30%)}	_{+2ms (+ 0.59%)}	_340ms	_343ms	_{p=0.040 n=6}
_{Req 4 - navto}	_{287ms (± 0.44%)}	_{288ms (± 0.28%)}	_~	_287ms	_289ms	_{p=0.082 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{91ms (± 2.20%)}	_{91ms (± 2.58%)}	_~	_86ms	_92ms	_{p=0.652 n=6}
_{CompilerTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{2,622ms (± 0.94%)}	_{2,616ms (± 0.49%)}	_~	_2,599ms	_2,638ms	_{p=0.810 n=6}
_{Req 2 - geterr}	_{4,115ms (± 0.55%)}	_{4,109ms (± 0.67%)}	_~	_4,072ms	_4,140ms	_{p=0.689 n=6}
_{Req 3 - references}	_{347ms (± 1.17%)}	_{348ms (± 1.07%)}	_~	_341ms	_351ms	_{p=0.807 n=6}
_{Req 4 - navto}	_{289ms (± 1.11%)}	_{289ms (± 0.79%)}	_~	_287ms	_293ms	_{p=1.000 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{73ms (± 3.62%)}	_{76ms (± 2.35%)}	_~	_74ms	_79ms	_{p=0.167 n=6}
_{xstateTSServer - node (v18.10.0, x64)}
_{Req 1 - updateOpen}	_{3,073ms (± 0.50%)}	_{3,101ms (± 0.91%)}	_~	_3,060ms	_3,139ms	_{p=0.108 n=6}
_{Req 2 - geterr}	_{1,599ms (± 0.86%)}	_{1,593ms (± 0.48%)}	_~	_1,582ms	_1,602ms	_{p=0.574 n=6}
_{Req 3 - references}	_{115ms (± 1.42%)}	_{118ms (± 5.79%)}	_~	_113ms	_132ms	_{p=0.222 n=6}
_{Req 4 - navto}	_{370ms (± 1.06%)}	_{371ms (± 0.98%)}	_~	_368ms	_377ms	_{p=0.370 n=6}
_{Req 5 - completionInfo count}	_{2,872 (± 0.00%)}	_{2,872 (± 0.00%)}	_~	_2,872	_2,872	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{379ms (± 2.24%)}	_{386ms (± 0.73%)}	_~	_383ms	_391ms	_{p=0.172 n=6}
_{Compiler-UnionsTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,638ms (± 0.94%)}	_{2,640ms (± 0.54%)}	_~	_2,618ms	_2,653ms	_{p=0.873 n=6}
_{Req 2 - geterr}	_{6,026ms (± 0.40%)}	_{6,048ms (± 0.42%)}	_~	_6,019ms	_6,089ms	_{p=0.149 n=6}
_{Req 3 - references}	_{351ms (± 0.87%)}	_{355ms (± 0.62%)}	_{+4ms (+ 1.09%)}	_352ms	_358ms	_{p=0.044 n=6}
_{Req 4 - navto}	_{290ms (± 1.32%)}	_{288ms (± 1.10%)}	_~	_283ms	_293ms	_{p=0.212 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{96ms (± 5.86%)}	_{99ms (± 0.99%)}	_~	_98ms	_100ms	_{p=0.402 n=6}
_{CompilerTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{2,799ms (± 0.33%)}	_{2,812ms (± 0.44%)}	_~	_2,788ms	_2,822ms	_{p=0.109 n=6}
_{Req 2 - geterr}	_{4,659ms (± 0.44%)}	_{4,660ms (± 0.52%)}	_~	_4,627ms	_4,695ms	_{p=1.000 n=6}
_{Req 3 - references}	_{364ms (± 0.69%)}	_{365ms (± 0.32%)}	_~	_363ms	_366ms	_{p=0.124 n=6}
_{Req 4 - navto}	_{283ms (± 0.66%)}	_{285ms (± 1.01%)}	_~	_281ms	_290ms	_{p=0.060 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{76ms (± 1.36%)}	_{76ms (± 0.99%)}	_~	_75ms	_77ms	_{p=0.437 n=6}
_{xstateTSServer - node (v16.17.1, x64)}
_{Req 1 - updateOpen}	_{3,221ms (± 0.20%)}	_{3,247ms (± 0.70%)}	_~	_3,210ms	_3,266ms	_{p=0.065 n=6}
_{Req 2 - geterr}	_{1,747ms (± 1.17%)}	_{1,748ms (± 0.62%)}	_~	_1,727ms	_1,757ms	_{p=0.748 n=6}
_{Req 3 - references}	_{123ms (± 1.40%)}	_{127ms (± 6.09%)}	_~	_123ms	_143ms	_{p=0.120 n=6}
_{Req 4 - navto}	_{355ms (± 0.58%)}	_{354ms (± 0.88%)}	_~	_349ms	_357ms	_{p=1.000 n=6}
_{Req 5 - completionInfo count}	_{2,872 (± 0.00%)}	_{2,872 (± 0.00%)}	_~	_2,872	_2,872	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{413ms (± 2.29%)}	_{416ms (± 1.72%)}	_~	_408ms	_426ms	_{p=0.521 n=6}
_{Compiler-UnionsTSServer - node (v14.21.3, x64)}
_{Req 1 - updateOpen}	_{2,760ms (± 0.73%)}	_{2,767ms (± 0.41%)}	_~	_2,749ms	_2,779ms	_{p=0.521 n=6}
_{Req 2 - geterr}	_{6,205ms (± 1.40%)}	_{6,175ms (± 0.73%)}	_~	_6,132ms	_6,258ms	_{p=0.575 n=6}
_{Req 3 - references}	_{360ms (± 0.72%)}	_{365ms (± 1.37%)}	_~	_359ms	_372ms	_{p=0.109 n=6}
_{Req 4 - navto}	_{292ms (± 1.24%)}	_{294ms (± 1.59%)}	_~	_290ms	_302ms	_{p=0.244 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{109ms (± 3.38%)}	_{108ms (± 7.03%)}	_~	_93ms	_113ms	_{p=0.744 n=6}
_{CompilerTSServer - node (v14.21.3, x64)}
_{Req 1 - updateOpen}	_{2,931ms (± 0.83%)}	_{2,944ms (± 0.59%)}	_~	_2,922ms	_2,967ms	_{p=0.471 n=6}
_{Req 2 - geterr}	_{4,559ms (± 0.73%)}	_{4,560ms (± 0.65%)}	_~	_4,529ms	_4,612ms	_{p=0.810 n=6}
_{Req 3 - references}	_{381ms (± 0.75%)}	_{381ms (± 1.05%)}	_~	_378ms	_387ms	_{p=0.936 n=6}
_{Req 4 - navto}	_{296ms (± 0.72%)}	_{298ms (± 0.35%)}	_{+3ms (+ 0.85%)}	_297ms	_300ms	_{p=0.049 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{82ms (± 1.47%)}	_{85ms (± 2.67%)}	_{+2ms (+ 2.63%)}	_83ms	_89ms	_{p=0.046 n=6}
_{xstateTSServer - node (v14.21.3, x64)}
_{Req 1 - updateOpen}	_{3,519ms (± 0.59%)}	_{3,530ms (± 0.50%)}	_~	_3,510ms	_3,558ms	_{p=0.261 n=6}
_{Req 2 - geterr}	_{1,871ms (± 0.69%)}	_{1,861ms (± 0.56%)}	_~	_1,847ms	_1,876ms	_{p=0.199 n=6}
_{Req 3 - references}	_{139ms (± 7.06%)}	_{146ms (± 7.02%)}	_~	_132ms	_153ms	_{p=0.463 n=6}
_{Req 4 - navto}	_{389ms (± 1.37%)}	_{391ms (± 1.22%)}	_~	_385ms	_397ms	_{p=0.419 n=6}
_{Req 5 - completionInfo count}	_{2,872 (± 0.00%)}	_{2,872 (± 0.00%)}	_~	_2,872	_2,872	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{421ms (± 1.48%)}	_{421ms (± 0.77%)}	_~	_418ms	_427ms	_{p=0.936 n=6}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-148-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v18.10.0, x64)
node (v16.17.1, x64)
node (v14.21.3, x64)

Scenarios

Compiler-UnionsTSServer - node (v18.10.0, x64)
Compiler-UnionsTSServer - node (v16.17.1, x64)
Compiler-UnionsTSServer - node (v14.21.3, x64)
CompilerTSServer - node (v18.10.0, x64)
CompilerTSServer - node (v16.17.1, x64)
CompilerTSServer - node (v14.21.3, x64)
xstateTSServer - node (v18.10.0, x64)
xstateTSServer - node (v16.17.1, x64)
xstateTSServer - node (v14.21.3, x64)

_Benchmark	_Name	_Iterations
_Current	₅₅₀₅₂	₆
_Baseline	_main	₆

Startup

Comparison Report - main..55052

_Metric	_main	₅₅₀₅₂	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v16.17.1, x64)}
_{Execution time}	_{142.45ms (± 0.21%)}	_{143.05ms (± 0.21%)}	_{+0.59ms (+ 0.42%)}	_142.18ms	_145.81ms	_{p=0.000 n=600}
_{tsserver-startup - node (v16.17.1, x64)}
_{Execution time}	_{222.13ms (± 0.23%)}	_{222.90ms (± 0.18%)}	_{+0.77ms (+ 0.35%)}	_221.77ms	_226.59ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v16.17.1, x64)}
_{Execution time}	_{224.33ms (± 0.28%)}	_{223.86ms (± 0.16%)}	_{-0.47ms (- 0.21%)}	_222.89ms	_228.96ms	_{p=0.000 n=600}
_{typescript-startup - node (v16.17.1, x64)}
_{Execution time}	_{205.80ms (± 0.23%)}	_{205.83ms (± 0.15%)}	_{+0.03ms (+ 0.01%)}	_205.03ms	_210.81ms	_{p=0.000 n=600}

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 5.4.0-148-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v16.17.1, x64)

Scenarios

tsc-startup - node (v16.17.1, x64)
tsserver-startup - node (v16.17.1, x64)
tsserverlibrary-startup - node (v16.17.1, x64)
typescript-startup - node (v16.17.1, x64)

_Benchmark	_Name	_Iterations
_Current	₅₅₀₅₂	₆
_Baseline	_main	₆

Developer Information:

Download Benchmark

typescript-bot · 2023-07-18T22:39:57Z

Hey @rbuckton, the results of running the DT tests are ready.
Everything looks the same!
You can check the log here.

rbuckton · 2023-08-09T20:28:24Z

@typescript-bot pack this

typescript-bot · 2023-08-09T20:28:27Z

Heya @rbuckton, I've started to run the tarball bundle task on this PR at 6a4f838. You can monitor the build here.

typescript-bot · 2023-08-09T20:30:06Z

Hey @rbuckton, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/156423/artifacts?artifactName=tgz&fileId=BBBB1882B63D1727843C1849163FCC29DE37D3F84D961910EDF835ACC1AB34AC02&fileName=/typescript-5.3.0-insiders.20230809.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.3.0-pr-55052-14".;

jakebailey · 2023-08-09T21:39:10Z

Leaving a random comment to test the new perf infra on this PR.

Update: The results are in!

src/compiler/checker.ts

ahejlsberg

This seems a lot more complex than I had expected. I'm not quite understanding why we need synthetic method calls and potentially overload resolution to figure this out.

src/compiler/checker.ts

rbuckton · 2023-09-26T01:18:43Z

The most recent commits address feedback from an offline discussion with @ahejlsberg. @ahejlsberg, can you take another look?

ahejlsberg

Suggest simplifying the error reporting per comments, otherwise looks good.

src/compiler/checker.ts

rbuckton · 2023-09-29T17:38:00Z

@typescript-bot cherry-pick this to release-5.3

typescript-bot · 2023-09-29T17:38:03Z

Heya @rbuckton, I've started to run the task to cherry-pick this into release-5.3 on this PR at 0554f56. You can monitor the build here.

typescript-bot · 2023-09-29T17:43:51Z

Hey @rbuckton, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-5.3 manually.

Component commits: 69f59da [WIP] Support custom 'Symbol.hasInstance' methods when checking/narrowing 'instanceof' 161d1f1 Add tests for instanceof and narrowing 6a4f838 Accept baseline, fix lint af6bb55 Check derived types when using type predicates with instanceof/hasInstance 6a83254 Small tweaks, lint fixes, and baseline updates 511c955 Add go-to-definition support on 'instanceof' keyword 9e3adb4 Merge branch 'main' into instanceof-Symbol.hasInstance 4b0eafc Fix format befa293 Address PR feedback 559047e Comment cleanup 8af777e Switch synthetic call to use use 'resolveSignature' flow f3e94f0 Merge branch 'main' into instanceof-Symbol.hasInstance 1d90af1 Run formatting b65f9bc Merge branch 'main' into instanceof-Symbol.hasInstance 0554f56 Remove branch for 'instanceof' error message reporting

jakebailey · 2023-09-29T17:53:35Z

I have no idea why the pick failed; I was going to say that it failed a the push stage but it got pushed above: typescript-bot@97bf30b

Probably some weird GH outage :|

(I am working on replacing this pick task anyway.)

rbuckton · 2023-09-29T17:54:38Z

It doesn't matter too much in this case. Daniel said he'd just update from main anyways.

[WIP] Support custom 'Symbol.hasInstance' methods when checking/narro…

69f59da

…wing 'instanceof'

typescript-bot assigned rbuckton Jul 17, 2023

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jul 17, 2023

Add tests for instanceof and narrowing

161d1f1

Accept baseline, fix lint

6a4f838

rbuckton requested review from andrewbranch, gabritto and sandersn July 17, 2023 22:12

rbuckton marked this pull request as ready for review July 17, 2023 22:12

rbuckton changed the title ~~[WIP] Support custom 'Symbol.hasInstance' methods when narrowing 'instanceof'~~ Support custom 'Symbol.hasInstance' methods when narrowing 'instanceof' Jul 17, 2023

gabritto reviewed Jul 18, 2023

View reviewed changes

src/compiler/checker.ts Outdated Show resolved Hide resolved

src/compiler/checker.ts Outdated Show resolved Hide resolved

src/compiler/checker.ts Outdated Show resolved Hide resolved

gabritto approved these changes Jul 18, 2023

View reviewed changes

rbuckton mentioned this pull request Jul 20, 2023

Refactor completions into a discriminated union engine262/engine262#222

Merged

sandersn reviewed Sep 19, 2023

View reviewed changes

src/compiler/checker.ts Outdated Show resolved Hide resolved

src/compiler/checker.ts Outdated Show resolved Hide resolved

src/compiler/checker.ts Show resolved Hide resolved

rbuckton added 2 commits September 19, 2023 15:18

Fix format

4b0eafc

Address PR feedback

befa293

sandersn approved these changes Sep 19, 2023

View reviewed changes

rbuckton requested a review from ahejlsberg September 20, 2023 20:34

ahejlsberg reviewed Sep 22, 2023

View reviewed changes

src/compiler/checker.ts Outdated Show resolved Hide resolved

src/compiler/checker.ts Outdated Show resolved Hide resolved

src/compiler/checker.ts Outdated Show resolved Hide resolved

src/compiler/checker.ts Outdated Show resolved Hide resolved

Comment cleanup

559047e

rbuckton commented Sep 22, 2023

View reviewed changes

src/compiler/checker.ts Outdated Show resolved Hide resolved

rbuckton added 3 commits September 25, 2023 20:47

Switch synthetic call to use use 'resolveSignature' flow

8af777e

Merge branch 'main' into instanceof-Symbol.hasInstance

f3e94f0

Run formatting

1d90af1

Merge branch 'main' into instanceof-Symbol.hasInstance

b65f9bc

ahejlsberg approved these changes Sep 28, 2023

View reviewed changes

src/compiler/checker.ts Outdated Show resolved Hide resolved

Remove branch for 'instanceof' error message reporting

0554f56

rbuckton merged commit 9cf44dc into main Sep 29, 2023

rbuckton deleted the instanceof-Symbol.hasInstance branch September 29, 2023 17:37

rbuckton restored the instanceof-Symbol.hasInstance branch September 29, 2023 17:39

rbuckton deleted the instanceof-Symbol.hasInstance branch September 29, 2023 17:43

rotu mentioned this pull request Nov 25, 2023

instanceof does not respect inherited Symbol.hasInstance #56536

Closed

Andarist mentioned this pull request Jul 7, 2024

Naked generic type returned from iterator method #59161

Open

This was referenced Jul 31, 2024

fix: unable to evaluate instanceof AjaxError ReactiveX/rxjs#6275

Merged

TS enforces left-hand side of instanceof must be an object type, but it can be any type. #59492

Closed

microsoft locked as resolved and limited conversation to collaborators Oct 22, 2025

Conversation

rbuckton commented Jul 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jul 17, 2023

Uh oh!

gabritto commented Jul 18, 2023

Uh oh!

typescript-bot commented Jul 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jul 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rbuckton commented Jul 18, 2023

Uh oh!

typescript-bot commented Jul 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jul 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jul 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jul 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jul 18, 2023

rxjs-src

/mnt/ts_downloads/rxjs-src/build.sh

Uh oh!

typescript-bot commented Jul 18, 2023

Compiler

TSServer

Startup

Uh oh!

typescript-bot commented Jul 18, 2023

Uh oh!

rbuckton commented Aug 9, 2023

Uh oh!

typescript-bot commented Aug 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Aug 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jakebailey commented Aug 9, 2023 • edited by typescript-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ahejlsberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rbuckton commented Sep 26, 2023

Uh oh!

ahejlsberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rbuckton commented Sep 29, 2023

Uh oh!

typescript-bot commented Sep 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Sep 29, 2023

Uh oh!

jakebailey commented Sep 29, 2023

Uh oh!

rbuckton commented Sep 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

rbuckton commented Jul 17, 2023 •

edited

Loading

typescript-bot commented Jul 18, 2023 •

edited

Loading

typescript-bot commented Jul 18, 2023 •

edited

Loading

typescript-bot commented Jul 18, 2023 •

edited

Loading

typescript-bot commented Jul 18, 2023 •

edited

Loading

typescript-bot commented Jul 18, 2023 •

edited

Loading

typescript-bot commented Jul 18, 2023 •

edited

Loading

typescript-bot commented Aug 9, 2023 •

edited

Loading

typescript-bot commented Aug 9, 2023 •

edited

Loading

jakebailey commented Aug 9, 2023 •

edited by typescript-bot

Loading

typescript-bot commented Sep 29, 2023 •

edited

Loading

rbuckton commented Sep 29, 2023 •

edited

Loading