Rename isParameterDeclaration to isPartOfParameterDeclaration#58251
Merged
jakebailey merged 1 commit intomicrosoft:mainfrom Apr 19, 2024
Merged
Rename isParameterDeclaration to isPartOfParameterDeclaration#58251jakebailey merged 1 commit intomicrosoft:mainfrom
jakebailey merged 1 commit intomicrosoft:mainfrom
Conversation
weswigham
approved these changes
Apr 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulled out of #52283.
This function has confused a number of people working on TS because it's named like a type guard, but it instead reports true for both actual parameter declarations and binding patterns within parameters.
isParameteris the type guard, which we should rename at some point.https://github.com/search?q=%2F%5Cbts%5C.isParameterDeclaration%5Cb%2F+%28language%3ATypeScript+OR+language%3AJavaScript%29&type=code shows that nobody is using this externally, so I think this should be safe to do.