Skip to content

Deemphasize old JSX transform#61586

Merged
RyanCavanaugh merged 1 commit intomicrosoft:mainfrom
eps1lon:emphasize-automatic-transform
Apr 17, 2025
Merged

Deemphasize old JSX transform#61586
RyanCavanaugh merged 1 commit intomicrosoft:mainfrom
eps1lon:emphasize-automatic-transform

Conversation

@eps1lon
Copy link
Contributor

@eps1lon eps1lon commented Apr 16, 2025 •
edited
Loading

People should choose the new, automatic transform
over the old transform which required a React import.

Test plan

Applied changes to local tsc code and ran pnpm tsc test.tsx --jsx:

$ pnpm tsc test.tsx --jsx
error TS6044: Compiler option 'jsx' expects an argument.
error TS6046: Argument for '--jsx' option must be: 'preserve', 'react-native', 'react-jsx', 'react-jsxdev', 'react'.

Fixes #61585

Related:

@github-project-automation github-project-automation bot moved this to Not started in PR Backlog Apr 16, 2025
@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Apr 16, 2025
@eps1lon eps1lon force-pushed the emphasize-automatic-transform branch from ee8452f to 5b0dfd9 Compare April 16, 2025 15:30
@eps1lon eps1lon force-pushed the emphasize-automatic-transform branch from 5b0dfd9 to 2fb9a19 Compare April 16, 2025 15:50
@eps1lon eps1lon mentioned this pull request Apr 16, 2025
Merged
@jakebailey
Copy link
Member

jakebailey commented Apr 16, 2025

I feel like this is fine, though I suspect there are other places where we order the message the other way around?

@eps1lon
Copy link
Contributor Author

eps1lon commented Apr 17, 2025

I couldn't find any when looking for --jsx and react-native.

@github-project-automation github-project-automation bot moved this from Not started to Needs merge in PR Backlog Apr 17, 2025
@RyanCavanaugh RyanCavanaugh merged commit 0a1aa6d into microsoft:main Apr 17, 2025
32 checks passed
@github-project-automation github-project-automation bot moved this from Needs merge to Done in PR Backlog Apr 17, 2025
@eps1lon eps1lon deleted the emphasize-automatic-transform branch April 17, 2025 18:55
@mrazauskas
Copy link
Contributor

mrazauskas commented Apr 19, 2025

there are other places where we order the message the other way around

Perhaps, the schema of tsconfig.json? Hard to say if different order would be reflected by code editors.

Reference: https://github.com/SchemaStore/schemastore/blob/ac8666004983f29014f320cb82c9bbe3ec44fae4/src/schemas/json/tsconfig.json#L349-L358

@sandersn sandersn removed this from PR Backlog Apr 22, 2025
@Andarist Andarist mentioned this pull request Oct 3, 2025
Merged
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@RyanCavanaugh RyanCavanaugh RyanCavanaugh approved these changes

@DanielRosenwasser DanielRosenwasser Awaiting requested review from DanielRosenwasser

Assignees

No one assigned

Labels

For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

--jsx react should be deemphasized

5 participants

@eps1lon @jakebailey @mrazauskas @RyanCavanaugh @typescript-bot