-
Notifications
You must be signed in to change notification settings - Fork 187
initial check-in #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@andxu, |
pom.xml
Outdated
| <version>0.0.1-SNAPSHOT</version> | ||
| <packaging>pom</packaging> | ||
| <properties> | ||
| <base.name>Vscode Java Debug Server</base.name> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Java Debug Server for Visual Studio Code
com.microsoft.java.debug/pom.xml
Outdated
| </parent> | ||
| <artifactId>com.microsoft.java.debug</artifactId> | ||
| <packaging>eclipse-plugin</packaging> | ||
| <name>${base.name} :: Debug</name> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:: Debugger Core
| </artifactItem> | ||
| <artifactItem> | ||
| <groupId>com.github.olivergondza</groupId> | ||
| <artifactId>maven-jdk-tools-wrapper</artifactId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's this? I didn't see this in the original pom file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will remove it
| <artifactId>tools</artifactId> | ||
| <version>1.8</version> | ||
| <scope>system</scope> | ||
| <systemPath>${java.home}/../lib/tools.jar</systemPath> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the maven-jdk-tools-wrapper for Maven to work with tools.jar?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the maven-jdk-tools-wrapper is used, do we still need to include tools.jar here?
From the link below, it seems unnecessary.
https://stackoverflow.com/questions/35240134/declare-maven-dependency-on-tools-jar-to-work-on-jdk-9/35244168#35244168
| <?eclipse version="3.4"?> | ||
| <plugin> | ||
| <extension | ||
| point="org.eclipse.m2e.core.lifecycleMappingMetadataSource"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need this extension?
* add initial debug plugin * add debug project in language server product * add copyright, remove startup class.
No description provided.