Skip to content

Conversation

@andxu
Copy link
Contributor

@andxu andxu commented Sep 7, 2017

No description provided.

@msftclas
Copy link

msftclas commented Sep 7, 2017

@andxu,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

pom.xml Outdated
<version>0.0.1-SNAPSHOT</version>
<packaging>pom</packaging>
<properties>
<base.name>Vscode Java Debug Server</base.name>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Java Debug Server for Visual Studio Code

</parent>
<artifactId>com.microsoft.java.debug</artifactId>
<packaging>eclipse-plugin</packaging>
<name>${base.name} :: Debug</name>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:: Debugger Core

</artifactItem>
<artifactItem>
<groupId>com.github.olivergondza</groupId>
<artifactId>maven-jdk-tools-wrapper</artifactId>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this? I didn't see this in the original pom file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will remove it

<artifactId>tools</artifactId>
<version>1.8</version>
<scope>system</scope>
<systemPath>${java.home}/../lib/tools.jar</systemPath>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the maven-jdk-tools-wrapper for Maven to work with tools.jar?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the maven-jdk-tools-wrapper is used, do we still need to include tools.jar here?
From the link below, it seems unnecessary.
https://stackoverflow.com/questions/35240134/declare-maven-dependency-on-tools-jar-to-work-on-jdk-9/35244168#35244168

<?eclipse version="3.4"?>
<plugin>
<extension
point="org.eclipse.m2e.core.lifecycleMappingMetadataSource">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need this extension?

andxu added a commit that referenced this pull request Sep 8, 2017
* add initial debug plugin

* add debug project in language server product

* add copyright, remove startup class.
@akaroml akaroml closed this Sep 8, 2017
@andxu andxu deleted the andy_dev1 branch November 22, 2017 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants