Skip to content

Mocha version update#1131

Merged
nikithauc merged 4 commits intodevfrom
nikithauc/mocha-update
Jan 11, 2023
Merged

Mocha version update#1131
nikithauc merged 4 commits intodevfrom
nikithauc/mocha-update

Conversation

@nikithauc
Copy link
Contributor

@nikithauc nikithauc commented Jan 10, 2023

  • Taking the latest version of mocha with is not compatible with esm library.
  • Added a simple tiny project to test if a ESM project with "type:module" compiles fine with the Graph JS library.

@nikithauc nikithauc requested a review from gavinbarron January 10, 2023 22:33
gavinbarron
gavinbarron approved these changes Jan 11, 2023
View reviewed changes
Copy link
Member

@gavinbarron gavinbarron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nikithauc nikithauc merged commit cd0ad63 into dev Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinbarron gavinbarron gavinbarron approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nikithauc @gavinbarron

Comments