Skip to content

Add total steps to StorageConfig #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pan-x-c merged 2 commits into from
Jul 9, 2025
Merged

Add total steps to StorageConfig #111

pan-x-c merged 2 commits into from
Jul 9, 2025

Conversation

@pan-x-c
Copy link
Collaborator

@pan-x-c pan-x-c commented Jul 4, 2025 •
edited
Loading

Description

Use total_steps to control the number of times the buffer can be read, which can directly limit the total steps of the training process.

It's an optional parameter. If set, the total_epochs parameter will be ignored.

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

pan-x-c
pan-x-c commented Jul 4, 2025
View reviewed changes
Copy link
Collaborator Author

@pan-x-c pan-x-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/run-unittest

@pan-x-c
Copy link
Collaborator Author

pan-x-c commented Jul 4, 2025

/run-unittest

@github-actions
Copy link

github-actions bot commented Jul 4, 2025

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
40 40 0 0 0 0 0 1.2s

Failed Tests

No failed tests ✨

Flaky Tests

No flaky tests ✨

Skipped

No skipped tests ✨

Tests

Test Name Status Flaky Duration
tests/algorithm/policy_loss_test.py::VerlPolicyLossTest::test_dpo_policy_loss ✅ 1ms
tests/algorithm/policy_loss_test.py::VerlPolicyLossTest::test_mix_policy_loss ✅ 1ms
tests/algorithm/policy_loss_test.py::VerlPolicyLossTest::test_opmd_policy_loss ✅ 1ms
tests/algorithm/policy_loss_test.py::VerlPolicyLossTest::test_ppo_policy_loss ✅ 1ms
tests/algorithm/policy_loss_test.py::VerlPolicyLossTest::test_sft_policy_loss ✅ 1ms
tests/buffer/file_test.py::TestFileBuffer::test_file_buffer ✅ 3ms
tests/buffer/file_test.py::TestFileBuffer::test_file_reader ✅ 1ms
tests/buffer/file_test.py::TestFileBuffer::test_file_writer ✅ 1ms
tests/buffer/queue_test.py::TestQueueBuffer::test_queue_buffer ✅ 5ms
tests/buffer/sql_test.py::TestSQLBuffer::test_create_sql_buffer ✅ 3ms
tests/common/config_test.py::TestConfig::test_all_examples_are_valid ✅ 1ms
tests/common/config_test.py::TestConfig::test_load_default_config ✅ 4ms
tests/common/experience_test.py::TestExperienceConversion::test_batch_conversion ✅ 1ms
tests/common/experience_test.py::TestExperienceConversion::test_experience_model_experience_conversion ✅ 1ms
tests/common/vllm_test.py::TestModelWrapperSyncV0::test_generate ✅ 42ms
tests/common/vllm_test.py::TestModelWrapperAsyncV0::test_generate ✅ 40ms
tests/common/vllm_test.py::TestModelWrapperAsyncTPV0::test_generate ✅ 50ms
tests/common/vllm_test.py::TestModelWrapperAsyncTPV1::test_generate ✅ 50ms
tests/common/vllm_test.py::TestModelWrapperAsyncV1::test_generate ✅ 38ms
tests/common/vllm_test.py::TestAPIServer::test_api ✅ 24ms
tests/common/vllm_test.py::TestTokenizer::test_assistant_token_mask ✅ 1ms
tests/explorer/explorer_test.py::BaseExplorerCase::test_explorer ✅ 1ms
tests/explorer/explorer_test.py::TestExplorerCountdownEval::test_explorer ✅ 104ms
tests/explorer/explorer_test.py::TestExplorerCountdownNoEval::test_explorer ✅ 105ms
tests/explorer/runner_pool_test.py::RunnerPoolTest::test_runner_pool ✅ 22ms
tests/explorer/runner_pool_test.py::RunnerPoolTest::test_runner_pool_with_auxiliary_models ✅ 4ms
tests/explorer/workflow_test.py::WorkflowTest::test_gsm8k_workflow ✅ 1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_boxed_workflow ✅ 1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_complex_workflow ✅ 1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_fraction_workflow ✅ 1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_workflow ✅ 1ms
tests/explorer/workflow_test.py::WorkflowTest::test_workflow_resettable ✅ 1ms
tests/trainer/trainer_test.py::BaseTrainerCase::test_trainer ✅ 1ms
tests/trainer/trainer_test.py::TestTrainerCountdown::test_trainer ✅ 255ms
tests/trainer/trainer_test.py::TestStepAheadAsyncRL::test_trainer ✅ 106ms
tests/trainer/trainer_test.py::TestTrainerGSM8K::test_trainer ✅ 60ms
tests/trainer/trainer_test.py::TestTrainerSFTWarmupGSM8K::test_trainer ✅ 84ms
tests/trainer/trainer_test.py::TestTrainerDPO::test_trainer ✅ 42ms
tests/trainer/trainer_test.py::TestFullyAsyncMode::test_fully_async_mode ✅ 109ms
tests/utils/plugin_test.py::TestPluginLoader::test_load_plugins ✅ 4ms

Github Test Reporter by CTRF 💚

@pan-x-c pan-x-c merged commit 30d2818 into modelscope:main Jul 9, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chenyushuo chenyushuo chenyushuo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pan-x-c @chenyushuo