-
Notifications
You must be signed in to change notification settings - Fork 47
Update the example of human in the loop #247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @HYLcool, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly enhances the human-in-the-loop capabilities by introducing a comprehensive and runnable example for Direct Preference Optimization (DPO). It provides all necessary components, including data, configurations, and updated documentation, to demonstrate how human preferences can be integrated into the DPO training pipeline. Additionally, it improves the flexibility of the task pipeline and adds robustness to data processing utilities.
Highlights
- New Human-in-the-Loop DPO Example: A complete example for DPO (Direct Preference Optimization) with human-in-the-loop data processing has been added, including a dedicated README, sample data, and configuration files.
- Documentation Update: The tutorial documentation has been updated to reflect the new human-in-the-loop example, providing clearer guidance and links to relevant configuration files.
- Task Pipeline Flexibility: The task pipeline logic has been refined to remove the restriction that it's only available in 'explore' or 'both' modes, and its output can now be derived from the trainer's experience buffer.
- Robustness Improvements: Checks have been added in data processing utilities to ensure the presence of 'Fields.stats' before attempting to access it, preventing potential errors.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the 'human in the loop' example by adding a new DPO example with necessary configuration, data, and documentation. The changes also include modifications to the task pipeline and configuration handling to support this new workflow. My review focuses on ensuring the new example is correct and runnable. I've found a few issues, mainly incorrect paths and links in the documentation and configuration files, which could prevent users from running the example successfully. I've also suggested some improvements to comments for better clarity.
|
/unittest-module-buffer |
Summary
Tests
Github Test Reporter by CTRF 💚 |
|
/unittest-module-service |
Summary
Tests
Github Test Reporter by CTRF 💚 |
|
/unittest-module-common |
Summary
Failed Tests
Tests
Github Test Reporter by CTRF 💚 |
|
/unittest-module-common |
Summary
Tests
Github Test Reporter by CTRF 💚 |
Description
As the title says.
Checklist
Please check the following items before code is ready to be reviewed.