Skip to content

Conversation

@garyzhang99
Copy link
Collaborator

Description

As the title says. The script for evaluating the train model on the BFCL benchmark is also provided.

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

@garyzhang99 garyzhang99 requested a review from hiyuchang October 10, 2025 06:44
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @garyzhang99, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the CHORD algorithm example by integrating a tool-use scenario using the ToolAce dataset. It provides clear, step-by-step guidance for setting up the environment, preparing models and datasets, and executing the CHORD training process. Furthermore, it introduces a robust evaluation pipeline for the trained models against the Berkeley Function-Calling Leaderboard (BFCL), ensuring comprehensive assessment of tool-use capabilities.

Highlights

  • CHORD Tool-Use Example: Introduces a new example for the CHORD algorithm focused on tool-use scenarios, specifically with the ToolAce Dataset.
  • Model and Dataset Preparation: Provides updated instructions for preparing models (e.g., "llama3.2-3b-instruct") and specifies pre-processed SFT and RL datasets from Hugging Face for the ToolAce example.
  • BFCL Evaluation Integration: Adds comprehensive documentation and scripts for evaluating trained CHORD models on the Berkeley Function-Calling Leaderboard (BFCL), including patching BFCL for custom model support.
  • New Configuration File: A dedicated configuration file ("mix_chord_toolace.yaml") is introduced to streamline running the CHORD algorithm with the ToolAce dataset.
  • Checkpoint Conversion Utility: Includes Python code snippets to convert trained model checkpoints into Hugging Face compatible format.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the CHORD example to use a tool-use case with the ToolAce dataset. It includes a new README with detailed instructions, a new configuration file, and scripts for evaluation on the BFCL benchmark. The changes are well-structured and provide a valuable new example. My review includes a few suggestions to improve the clarity and robustness of the documentation, particularly around file paths and variable definitions, to ensure users can run the example smoothly. I also found a few minor issues in the provided patch file for BFCL support, such as a typo and missing docstrings.

@hiyuchang hiyuchang merged commit 15a2cd8 into modelscope:main Oct 11, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants