-
Notifications
You must be signed in to change notification settings - Fork 47
Update chord with tooluse example #313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @garyzhang99, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the CHORD algorithm example by integrating a tool-use scenario using the ToolAce dataset. It provides clear, step-by-step guidance for setting up the environment, preparing models and datasets, and executing the CHORD training process. Furthermore, it introduces a robust evaluation pipeline for the trained models against the Berkeley Function-Calling Leaderboard (BFCL), ensuring comprehensive assessment of tool-use capabilities. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the CHORD example to use a tool-use case with the ToolAce dataset. It includes a new README with detailed instructions, a new configuration file, and scripts for evaluation on the BFCL benchmark. The changes are well-structured and provide a valuable new example. My review includes a few suggestions to improve the clarity and robustness of the documentation, particularly around file paths and variable definitions, to ensure users can run the example smoothly. I also found a few minor issues in the provided patch file for BFCL support, such as a typo and missing docstrings.
Description
As the title says. The script for evaluating the train model on the BFCL benchmark is also provided.
Checklist
Please check the following items before code is ready to be reviewed.