Skip to content

[Feature] Add MIX algorithm #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pan-x-c merged 9 commits into from
Jun 17, 2025
Merged

[Feature] Add MIX algorithm #83

pan-x-c merged 9 commits into from
Jun 17, 2025

Conversation

@hiyuchang
Copy link
Collaborator

@hiyuchang hiyuchang commented Jun 17, 2025 •
edited
Loading

Description

  1. [Bug Fix] Add rollout configs
  2. [Refactor] Minor revision for dp_actor.py
  3. [Feature] Add MIX algorithm (GRPO + SFT losses)

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

@hiyuchang
Copy link
Collaborator Author

hiyuchang commented Jun 17, 2025

/run-unittest

@github-actions
Copy link

github-actions bot commented Jun 17, 2025

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
29 29 0 0 0 0 0 1.0s

Failed Tests

No failed tests ✨

Flaky Tests

No flaky tests ✨

Skipped

No skipped tests ✨

Tests

Test Name Status Flaky Duration
tests/buffer/queue_test.py::TestQueueBuffer::test_queue_buffer ✅ 5ms
tests/buffer/sql_test.py::TestSQLBuffer::test_create_sql_buffer ✅ 3ms
tests/common/config_test.py::TestConfig::test_all_examples_are_valid ✅ 1ms
tests/common/config_test.py::TestConfig::test_load_default_config ✅ 5ms
tests/common/experience_test.py::TestExperienceConversion::test_batch_conversion ✅ 1ms
tests/common/experience_test.py::TestExperienceConversion::test_experience_model_experience_conversion ✅ 1ms
tests/common/vllm_test.py::TestModelWrapperSyncV0::test_generate ✅ 44ms
tests/common/vllm_test.py::TestModelWrapperAsyncV0::test_generate ✅ 43ms
tests/common/vllm_test.py::TestModelWrapperAsyncTPV0::test_generate ✅ 52ms
tests/common/vllm_test.py::TestModelWrapperAsyncTPV1::test_generate ✅ 54ms
tests/common/vllm_test.py::TestModelWrapperAsyncV1::test_generate ✅ 39ms
tests/common/vllm_test.py::TestAPIServer::test_api ✅ 22ms
tests/common/vllm_test.py::TestTokenizer::test_assistant_token_mask ✅ 1ms
tests/explorer/explorer_test.py::BaseExplorerCase::test_explorer ✅ 1ms
tests/explorer/explorer_test.py::TestExplorerCountdownEval::test_explorer ✅ 109ms
tests/explorer/explorer_test.py::TestExplorerCountdownNoEval::test_explorer ✅ 138ms
tests/explorer/runner_pool_test.py::RunnerPoolTest::test_runner_pool ✅ 23ms
tests/explorer/runner_pool_test.py::RunnerPoolTest::test_runner_pool_with_auxiliary_models ✅ 4ms
tests/explorer/workflow_test.py::WorkflowTest::test_gsm8k_workflow ✅ 1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_complex_workflow ✅ 1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_fraction_workflow ✅ 1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_workflow ✅ 1ms
tests/explorer/workflow_test.py::WorkflowTest::test_workflow_resettable ✅ 1ms
tests/trainer/trainer_test.py::BaseTrainerCase::test_trainer ✅ 1ms
tests/trainer/trainer_test.py::TestTrainerCountdown::test_trainer ✅ 290ms
tests/trainer/trainer_test.py::TestTrainerGSM8K::test_trainer ✅ 60ms
tests/trainer/trainer_test.py::TestTrainerGSM8KWithSFT::test_trainer ✅ 64ms
tests/trainer/trainer_test.py::TestTrainerDPO::test_trainer ✅ 54ms
tests/utils/plugin_test.py::TestPluginLoader::test_load_plugins ✅ 4ms

Github Test Reporter by CTRF 💚

@hiyuchang
Copy link
Collaborator Author

hiyuchang commented Jun 17, 2025

/run-unittest

@pan-x-c pan-x-c merged commit b8d1faa into modelscope:algorithm_dev Jun 17, 2025
2 checks passed
@github-actions
Copy link

github-actions bot commented Jun 17, 2025

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
29 28 1 0 0 0 0 1.0s

Failed Tests

Failed Tests ❌ Fail Message
❌ tests/common/config_test.py::TestConfig::test_all_examples_are_valid The test failed in the call phase due to an exception

Flaky Tests

No flaky tests ✨

Skipped

No skipped tests ✨

Tests

Test Name Status Flaky Duration
tests/buffer/queue_test.py::TestQueueBuffer::test_queue_buffer ✅ 5ms
tests/buffer/sql_test.py::TestSQLBuffer::test_create_sql_buffer ✅ 3ms
tests/common/config_test.py::TestConfig::test_all_examples_are_valid ❌ 1ms
tests/common/config_test.py::TestConfig::test_load_default_config ✅ 6ms
tests/common/experience_test.py::TestExperienceConversion::test_batch_conversion ✅ 1ms
tests/common/experience_test.py::TestExperienceConversion::test_experience_model_experience_conversion ✅ 1ms
tests/common/vllm_test.py::TestModelWrapperSyncV0::test_generate ✅ 44ms
tests/common/vllm_test.py::TestModelWrapperAsyncV0::test_generate ✅ 42ms
tests/common/vllm_test.py::TestModelWrapperAsyncTPV0::test_generate ✅ 52ms
tests/common/vllm_test.py::TestModelWrapperAsyncTPV1::test_generate ✅ 53ms
tests/common/vllm_test.py::TestModelWrapperAsyncV1::test_generate ✅ 39ms
tests/common/vllm_test.py::TestAPIServer::test_api ✅ 21ms
tests/common/vllm_test.py::TestTokenizer::test_assistant_token_mask ✅ 1ms
tests/explorer/explorer_test.py::BaseExplorerCase::test_explorer ✅ 1ms
tests/explorer/explorer_test.py::TestExplorerCountdownEval::test_explorer ✅ 120ms
tests/explorer/explorer_test.py::TestExplorerCountdownNoEval::test_explorer ✅ 147ms
tests/explorer/runner_pool_test.py::RunnerPoolTest::test_runner_pool ✅ 23ms
tests/explorer/runner_pool_test.py::RunnerPoolTest::test_runner_pool_with_auxiliary_models ✅ 4ms
tests/explorer/workflow_test.py::WorkflowTest::test_gsm8k_workflow ✅ 1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_complex_workflow ✅ 1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_fraction_workflow ✅ 1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_workflow ✅ 1ms
tests/explorer/workflow_test.py::WorkflowTest::test_workflow_resettable ✅ 1ms
tests/trainer/trainer_test.py::BaseTrainerCase::test_trainer ✅ 1ms
tests/trainer/trainer_test.py::TestTrainerCountdown::test_trainer ✅ 290ms
tests/trainer/trainer_test.py::TestTrainerGSM8K::test_trainer ✅ 61ms
tests/trainer/trainer_test.py::TestTrainerGSM8KWithSFT::test_trainer ✅ 65ms
tests/trainer/trainer_test.py::TestTrainerDPO::test_trainer ✅ 54ms
tests/utils/plugin_test.py::TestPluginLoader::test_load_plugins ✅ 4ms

Github Test Reporter by CTRF 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hiyuchang @pan-x-c