Skip to content

Unify async/sync RL #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yanxi-chen merged 11 commits into from
Jun 20, 2025
Merged

Unify async/sync RL #91

yanxi-chen merged 11 commits into from
Jun 20, 2025

Conversation

@pan-x-c
Copy link
Collaborator

@pan-x-c pan-x-c commented Jun 19, 2025

Description

As the title says

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

@pan-x-c pan-x-c changed the title [WIP] Unify async/sync RL Unify async/sync RL Jun 19, 2025
@pan-x-c
Copy link
Collaborator Author

pan-x-c commented Jun 19, 2025

/run-unittest

@github-actions
Copy link

github-actions bot commented Jun 19, 2025

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
36 36 0 0 0 0 0 983ms

Failed Tests

No failed tests ✨

Flaky Tests

No flaky tests ✨

Skipped

No skipped tests ✨

Tests

Test Name Status Flaky Duration
tests/algorithm/policy_loss_test.py::VerlPolicyLossTest::test_dpo_policy_loss ✅ 1ms
tests/algorithm/policy_loss_test.py::VerlPolicyLossTest::test_mix_policy_loss ✅ 1ms
tests/algorithm/policy_loss_test.py::VerlPolicyLossTest::test_opmd_policy_loss ✅ 1ms
tests/algorithm/policy_loss_test.py::VerlPolicyLossTest::test_ppo_policy_loss ✅ 1ms
tests/algorithm/policy_loss_test.py::VerlPolicyLossTest::test_sft_policy_loss ✅ 1ms
tests/buffer/file_test.py::TestFileBuffer::test_file_reader ✅ 1ms
tests/buffer/file_test.py::TestFileBuffer::test_file_writer ✅ 3ms
tests/buffer/queue_test.py::TestQueueBuffer::test_queue_buffer ✅ 2ms
tests/buffer/sql_test.py::TestSQLBuffer::test_create_sql_buffer ✅ 3ms
tests/common/config_test.py::TestConfig::test_all_examples_are_valid ✅ 1ms
tests/common/config_test.py::TestConfig::test_load_default_config ✅ 6ms
tests/common/experience_test.py::TestExperienceConversion::test_batch_conversion ✅ 1ms
tests/common/experience_test.py::TestExperienceConversion::test_experience_model_experience_conversion ✅ 1ms
tests/common/vllm_test.py::TestModelWrapperSyncV0::test_generate ✅ 42ms
tests/common/vllm_test.py::TestModelWrapperAsyncV0::test_generate ✅ 40ms
tests/common/vllm_test.py::TestModelWrapperAsyncTPV0::test_generate ✅ 51ms
tests/common/vllm_test.py::TestModelWrapperAsyncTPV1::test_generate ✅ 50ms
tests/common/vllm_test.py::TestModelWrapperAsyncV1::test_generate ✅ 38ms
tests/common/vllm_test.py::TestAPIServer::test_api ✅ 24ms
tests/common/vllm_test.py::TestTokenizer::test_assistant_token_mask ✅ 1ms
tests/explorer/explorer_test.py::BaseExplorerCase::test_explorer ✅ 1ms
tests/explorer/explorer_test.py::TestExplorerCountdownEval::test_explorer ✅ 94ms
tests/explorer/explorer_test.py::TestExplorerCountdownNoEval::test_explorer ✅ 118ms
tests/explorer/runner_pool_test.py::RunnerPoolTest::test_runner_pool ✅ 22ms
tests/explorer/runner_pool_test.py::RunnerPoolTest::test_runner_pool_with_auxiliary_models ✅ 4ms
tests/explorer/workflow_test.py::WorkflowTest::test_gsm8k_workflow ✅ 1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_complex_workflow ✅ 1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_fraction_workflow ✅ 1ms
tests/explorer/workflow_test.py::WorkflowTest::test_math_workflow ✅ 1ms
tests/explorer/workflow_test.py::WorkflowTest::test_workflow_resettable ✅ 1ms
tests/trainer/trainer_test.py::BaseTrainerCase::test_trainer ✅ 1ms
tests/trainer/trainer_test.py::TestTrainerCountdown::test_trainer ✅ 275ms
tests/trainer/trainer_test.py::TestTrainerGSM8K::test_trainer ✅ 64ms
tests/trainer/trainer_test.py::TestTrainerGSM8KWithSFT::test_trainer ✅ 65ms
tests/trainer/trainer_test.py::TestTrainerDPO::test_trainer ✅ 59ms
tests/utils/plugin_test.py::TestPluginLoader::test_load_plugins ✅ 4ms

Github Test Reporter by CTRF 💚

@yanxi-chen yanxi-chen merged commit 99a772a into modelscope:algorithm_dev Jun 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pan-x-c @yanxi-chen