Fix to replace _rsync with _fileCopy#254
Merged
DeviaVir merged 4 commits intomotdotla:masterfrom May 2, 2017
Merged
Conversation
If there is a problem with `_ fileCopy`, it is possible to switch to `_rsync` in the environment variable
DeviaVir
approved these changes
May 2, 2017
Collaborator
DeviaVir
left a comment
There was a problem hiding this comment.
Interesting, would it make sense to only use _fileCopy in the case of Windows, and rsync with other platforms? Is there an optimization to be had there?
Contributor
Author
|
@DeviaVir As the difference in speed is really small, should we use |
Collaborator
|
@abetomo long as |
Contributor
Author
|
@DeviaVir Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation for a problem, processing that can be switched by environment variable is put in place.
If the next version has been released and there are no major problems, Replace with
_fileCopy.