Added the ability to set constants when scheduling a Lambda function Cloudwatch event.#364
Closed
svanhart wants to merge 1 commit intomotdotla:masterfrom
svanhart:add_inputs_to_event_target
Closed
Added the ability to set constants when scheduling a Lambda function Cloudwatch event.#364svanhart wants to merge 1 commit intomotdotla:masterfrom svanhart:add_inputs_to_event_target
svanhart wants to merge 1 commit intomotdotla:masterfrom
svanhart:add_inputs_to_event_target
Conversation
…Cloudwatch event.
DeviaVir
reviewed
Aug 2, 2017
Collaborator
DeviaVir
left a comment
There was a problem hiding this comment.
one small nit and one backward compatibility comment.
Thanks for taking the time to make node-lambda better 👍
| Arn: params.FunctionArn, | ||
| Id: this._functionName(params) | ||
| Id: this._functionName(params), | ||
| Input: JSON.stringify(params.Input) |
Collaborator
There was a problem hiding this comment.
We may want to have this backwards compatible by making this optional, i.e. params.hasOwnProperty('Input') ? JSON.stringify(params.Input) : ""
| "ScheduleExpression": "rate(1 hour)", | ||
| "Input": | ||
| { | ||
| "key": "value", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed the ability to pass variables to a Lambda function from a Cloudwatch event so that depending upon when the event was triggered would dictate which path the code takes.