Skip to content

Remove code and tests for unsupported Python 2.6, 3.3 and 3.4 #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
methane merged 7 commits into from
Nov 2, 2017
Merged

Remove code and tests for unsupported Python 2.6, 3.3 and 3.4 #249

methane merged 7 commits into from
Nov 2, 2017

Conversation

@hugovk
Copy link
Contributor

@hugovk hugovk commented Oct 12, 2017 •
edited
Loading

c11bb64 says:

Python 3.3 and 3.4 will not be supported officially in next minor version

And 2.6 was dropped in #168.

This removes some 2.6, 3.3 and 3.4 stuff.

Also remove this restriction form .travis.yml to allow me to test this feature branch before creating the PR:

-branches:		
-  only:		
-    - master		
-

I think this is a good thing to keep, but let me know if you'd like it putting back.

Also ignore .cache directory, created from build/test.

@hugovk
Copy link
Contributor Author

hugovk commented Oct 12, 2017

The Docker CI failure also happens on master.

@methane
Copy link
Member

methane commented Oct 12, 2017

I just want don't announce "Python 3.3 and 3.4 are supported."
Don't remove test until it make trouble.

@methane
Copy link
Member

methane commented Oct 12, 2017

Removing code for 2.6 is nice.

@hugovk hugovk mentioned this pull request Oct 12, 2017
Merged
@hugovk
Copy link
Contributor Author

hugovk commented Oct 12, 2017

Please see #250.

@hugovk
Copy link
Contributor Author

hugovk commented Nov 1, 2017

Merge conflict resolved.

@hugovk
Copy link
Contributor Author

hugovk commented Nov 1, 2017

By the way, here's the pip installs for msgpack-python from PyPI for the last month:

$ pypinfo --percent --pip msgpack-python pyversion
python_version percent download_count
-------------- ------- --------------
2.7              83.9%        669,038
3.6               6.6%         52,967
3.5               6.2%         49,744
3.4               2.9%         22,903
2.6               0.2%          1,980
3.3               0.1%            484
3.7               0.0%            278
None              0.0%              6
3.2               0.0%              3
3.1               0.0%              1

This shows Python 2.6 and 3.3 have very little usage.

@methane
Copy link
Member

methane commented Nov 2, 2017

OK, simplifying appveyor.yml looks nice.

@methane methane merged commit 3a09885 into msgpack:master Nov 2, 2017
@methane
Copy link
Member

methane commented Nov 2, 2017

thanks

@hugovk hugovk deleted the rm-unsupported branch November 2, 2017 09:17
@FelixSchwarz FelixSchwarz mentioned this pull request Jul 13, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hugovk @methane