add a .has() method #131 #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Member
|
@regevbr yes there are breaking changes in the pipeline. we will be dropping support for node < 6.x (maybe even 6.x) in the next major release. Code is nice and should work, but the call to PS: CoffeeScript has an existential operator: instead of |
Contributor
Author
|
@erdii thanks! that is a good catch - I fixed the code and added tests to that use case. About the deprecation, please keep support for node 6 as I'm stuck with it sadly and not in a position to upgrade. |
Member
|
@regevbr Ok I'll bring that up when we'll talk about compatibility! Thanks for your work here! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a .has() method #131