Skip to content

Conversation

@sujeshthekkepatt
Copy link
Contributor

Adds mset feature. Please take look @erdii . Still needs to add the tests. Once the code seems okay I will add the tests.

Copy link
Member

@erdii erdii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good :)

@sujeshthekkepatt
Copy link
Contributor Author

@erdii I have updated it. Now how are the tests need to be written? Need to have,

  1. mset functionality test
  2. mset maxkeys check
  3. ttl integer check test

Any other tests ?

@erdii erdii requested review from daluf and erdii and removed request for erdii September 5, 2019 12:01
@daluf daluf merged commit abe8a44 into node-cache:master Sep 5, 2019
@daluf daluf mentioned this pull request Sep 5, 2019
@sujeshthekkepatt sujeshthekkepatt deleted the mset-feature branch September 5, 2019 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants