Skip to content

Comments

chore(readme): add a global profile on the org readme#10

Merged
Trott merged 5 commits intonodejs:mainfrom
ovflowd:chore/add-public-profile
Apr 4, 2023
Merged

chore(readme): add a global profile on the org readme#10
Trott merged 5 commits intonodejs:mainfrom
ovflowd:chore/add-public-profile

Conversation

@ovflowd
Copy link
Member

@ovflowd ovflowd commented Mar 21, 2023

This PR adds a public profile on the GitHub organisation, adding handy links and a nice overview of the Node.js GitHub org.

cc @nodejs/tsc

@Trott
Copy link
Member

Trott commented Mar 21, 2023

Should probably be changed to non-HTML markdown where possible, but that's not a requirement for landing initially. Someone can come by and fix that up later (or never).

@ovflowd
Copy link
Member Author

ovflowd commented Mar 21, 2023

I tried to replace a few things with pure Markdown, but it loses its alignment. I think it's fine for now but def as you mentioned something we can just reiterate as we need.

Co-authored-by: Tobias Nießen <tniessen@tnie.de>
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! I think we should mention our governance model here, and how to contribute to the project.

@ovflowd
Copy link
Member Author

ovflowd commented Mar 22, 2023

@mcollina as a second paragraph or what? 👀

@mcollina
Copy link
Member

Yes. I think we can expand on that copy a bit. Anyway, this is good and it can land.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I think we can expand on that copy a bit. Anyway, this is good and it can land.

@ovflowd
Copy link
Member Author

ovflowd commented Mar 22, 2023

@mcollina I added a few paragraphs, please feel free to review!

targos
targos previously approved these changes Mar 22, 2023
@targos targos dismissed their stale review March 22, 2023 12:46

outdated

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ovflowd
Copy link
Member Author

ovflowd commented Apr 4, 2023

@Trott can we get this merged?

@Trott Trott merged commit 44cc40e into nodejs:main Apr 4, 2023
@ovflowd ovflowd deleted the chore/add-public-profile branch April 4, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants