Skip to content

Comments

hotfix: fix broken image#18

Merged
MoLow merged 1 commit intomainfrom
fix-broken-image
Sep 24, 2023
Merged

hotfix: fix broken image#18
MoLow merged 1 commit intomainfrom
fix-broken-image

Conversation

@ovflowd
Copy link
Member

@ovflowd ovflowd commented Sep 23, 2023

cc @nodejs/tsc

@bmuenzenmeyer
Copy link

bmuenzenmeyer commented Sep 23, 2023

for more context: noticed this after our Grace Hopper Open Source Day work - this image was being hotlinked from the website repo- and deleted thinking it had no references - which is obviosuly an unsafe practice leading to situations like this - linking to the org logo as @ovflowd does here is safer

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ovflowd
Copy link
Member Author

ovflowd commented Sep 24, 2023

Can we get this merged?

@MoLow MoLow merged commit 5fa0c0d into main Sep 24, 2023
@MoLow MoLow deleted the fix-broken-image branch September 24, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants