This repository was archived by the owner on Jul 20, 2018. It is now read-only.
Set loglevel to notice when installing npm packages#36
Merged
pesho merged 1 commit intonodejs:masterfrom Mar 10, 2015
Merged
Conversation
Contributor
|
LGTM, thanks 👍 |
pesho
added a commit
that referenced
this pull request
Mar 10, 2015
Set loglevel to notice when installing npm packages
Contributor
|
@Starefossen according to docker-library/official-images#543 (comment) the same can be achieved using an environment variable. Do you think we should: (a) just revert this change and leave it to the user to set (b) set |
Starefossen
pushed a commit
to Starefossen/docker-iojs
that referenced
this pull request
Mar 10, 2015
Member
Author
|
I have submitted a new PR which reverts this one and adds |
Starefossen
pushed a commit
to Starefossen/docker-node
that referenced
this pull request
Mar 4, 2016
Close: nodejs#57 Related: nodejs/docker-iojs#36 Signed-off-by: Hans Kristian Flaatten <hans.kristian.flaatten@dnt.no>
Starefossen
pushed a commit
to Starefossen/docker-node
that referenced
this pull request
Jun 24, 2016
Close: nodejs#57 Related: nodejs/docker-iojs#36 Signed-off-by: Hans Kristian Flaatten <hans.kristian.flaatten@dnt.no>
Starefossen
pushed a commit
to Starefossen/docker-node
that referenced
this pull request
Jun 24, 2016
Close: nodejs#57 Related: nodejs/docker-iojs#36 Signed-off-by: Hans Kristian Flaatten <hans.kristian.flaatten@dnt.no>
Starefossen
pushed a commit
to Starefossen/docker-node
that referenced
this pull request
Jun 24, 2016
Close: nodejs#57 Related: nodejs/docker-iojs#36 Signed-off-by: Hans Kristian Flaatten <hans.kristian.flaatten@dnt.no>
Starefossen
pushed a commit
to Starefossen/docker-node
that referenced
this pull request
Jun 24, 2016
Close: nodejs#57 Related: nodejs/docker-iojs#36 Signed-off-by: Hans Kristian Flaatten <hans.kristian.flaatten@dnt.no>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR sets
--logleveltonoticewhen installing npm packages in theONBUILDimage.Rationale:
Packages breaks from time to time. By default npm has
--loglevelset towarningwhen installing, and if the install fails for some reason the entire log is written tonpm-debug.log. If you have not mounted/usr/src/appas a volume this file is now inside of the container which just exited.In order to view the log you will have to copy the file from the docker container onto you host using the
docker cpcommand. In my opinion this creates unnecessary overhead, and may not be entirely intuitive to novices.