Change baseimage for node:slim to stretch release#822
Change baseimage for node:slim to stretch release#822mkumatag wants to merge 1 commit intonodejs:masterfrom
Conversation
|
/cc @PeterDaveHello |
|
/cc @nodejs/docker |
How it works? I see those 2 packages are missing, so do you want me to create a separate template called |
|
I suppose we should discuss before making changes, let's move back to the issue. |
|
I think the changes have to be made to the following file: https://github.com/nodejs/docker-node/blob/master/Dockerfile-slim.template Then the update will be picked up on next release. |
b740868 to
ea64116
Compare
|
@LaurentGoderre can you drop your suggestion in #821 ? |
|
Would it be better to just have a separate stretch-slim variant rather than modifying the current slim variant? I'm thinking we should treat it like we do with the default variant. |
|
@PeterDaveHello @LaurentGoderre I just made suggested changes, PTAL and let me know if anything else is required.? |
|
@chorrell do you mean we'd have a |
|
Yeah |
|
@PeterDaveHello are your requests satisfied? Seems like this could be merged now. |
|
I opened #850 as an alternative for a smoother transition. |
|
Closing as this was addressed via #850 |
Fixes: #821