Conversation
Notable Changes: - Teach llnode how to print Symbol properties names Commits: - [fdb49b8] doc: fix typo in README.md (hardfist) - [51bf1f6] src: fix formatting of context address within JSFunction (Matheus Marchini) - [a36611f] test: move workqueue tests to correct folder (Matheus Marchini) - [0c1e3ae] src: make source list -l flag optional (Matheus Marchini) - [a295239] src: refactor JSError stringifier (Matheus Marchini) - [9f3dce3] build: add coverage for javascript code (Matheus Marchini) - [43edf43] build: add support to gcov and codecov (Matheus Marchini) - [59b65c4] build: add support for Android Termux build (James R. Gambale, Jr) - [e30beba] src: teach llnode how to print Symbol properties names (Matheus Marchini) - [388605f] src: fix performance regression (Matheus Marchini) - [dbd95d7] build: load lldb symbols at runtime (Dane Springmeyer) - [c17d0d1] src: fix build on older compilers (gcc 4.8) (Matheus Marchini) - [c851b9a] src: introduce Printer class (Matheus Marchini)
Codecov Report
@@ Coverage Diff @@
## master #269 +/- ##
=======================================
Coverage 79.36% 79.36%
=======================================
Files 34 34
Lines 4338 4338
=======================================
Hits 3443 3443
Misses 895 895Continue to review full report at Codecov.
|
Contributor
Author
|
cc @nodejs/llnode |
joyeecheung
approved these changes
Feb 22, 2019
cjihrig
approved these changes
Feb 22, 2019
mmarchini
added a commit
that referenced
this pull request
Feb 22, 2019
Notable Changes: - Teach llnode how to print Symbol properties names Commits: - [fdb49b8] doc: fix typo in README.md (hardfist) - [51bf1f6] src: fix formatting of context address within JSFunction (Matheus Marchini) - [a36611f] test: move workqueue tests to correct folder (Matheus Marchini) - [0c1e3ae] src: make source list -l flag optional (Matheus Marchini) - [a295239] src: refactor JSError stringifier (Matheus Marchini) - [9f3dce3] build: add coverage for javascript code (Matheus Marchini) - [43edf43] build: add support to gcov and codecov (Matheus Marchini) - [59b65c4] build: add support for Android Termux build (James R. Gambale, Jr) - [e30beba] src: teach llnode how to print Symbol properties names (Matheus Marchini) - [388605f] src: fix performance regression (Matheus Marchini) - [dbd95d7] build: load lldb symbols at runtime (Dane Springmeyer) - [c17d0d1] src: fix build on older compilers (gcc 4.8) (Matheus Marchini) - [c851b9a] src: introduce Printer class (Matheus Marchini) PR-URL: #269 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Contributor
Author
|
Landed in c7ede80 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notable Changes:
Commits:
(Matheus Marchini)
Marchini)
Gambale, Jr)
(Matheus Marchini)
Marchini)