Closed
Conversation
Codecov Report
@@ Coverage Diff @@
## master #276 +/- ##
=======================================
Coverage 81.23% 81.23%
=======================================
Files 34 34
Lines 4369 4369
=======================================
Hits 3549 3549
Misses 820 820
Continue to review full report at Codecov.
|
Contributor
Author
|
cc @nodejs/llnode |
richardlau
approved these changes
Mar 12, 2019
cjihrig
approved these changes
Mar 12, 2019
mmarchini
added a commit
that referenced
this pull request
Mar 25, 2019
PR-URL: #276 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
mmarchini
added a commit
that referenced
this pull request
Mar 25, 2019
PR-URL: #276 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Contributor
Author
|
Landed in ecfbdca...62ca523 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since GitHub/Travis won't rerun tests for Pull Requests when
masteris updated, some commits landed after 85f067a, which made our linter test fail on `master. Also, since there are only a few open pull requests now, this is unlikely to happen again.