src: reduce redundant "error:" for inspect and findrefs#285
Closed
oyyd wants to merge 1 commit intonodejs:masterfrom
Closed
src: reduce redundant "error:" for inspect and findrefs#285oyyd wants to merge 1 commit intonodejs:masterfrom
inspect and findrefs#285oyyd wants to merge 1 commit intonodejs:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #285 +/- ##
=========================================
+ Coverage 80.56% 80.8% +0.23%
=========================================
Files 33 33
Lines 4116 4120 +4
=========================================
+ Hits 3316 3329 +13
+ Misses 800 791 -9
Continue to review full report at Codecov.
|
bf744bf to
27d8016
Compare
When `inspect` or `findrefs` an invalid expr, llnode will print an error message prefixed with "error: error: error:". This PR will reduce one redundant "error:" for such scenario and it seems that we can't remove the other redundant "error:" by calling SB API only.
27d8016 to
b678289
Compare
mmarchini
approved these changes
Jul 19, 2019
mmarchini
pushed a commit
that referenced
this pull request
Jul 19, 2019
When `inspect` or `findrefs` an invalid expr, llnode will print an error message prefixed with "error: error: error:". This PR will reduce one redundant "error:" for such scenario and it seems that we can't remove the other redundant "error:" by calling SB API only. PR-URL: #285 Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Contributor
|
Landed in 74414fc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
inspectorfindrefsan invalid expr, llnode will printan error message prefixed with "error: error: error:". This PR
will reduce one redundant "error:" for such scenario and it
seems that we can't remove the other redundant "error:" by
calling SB API only.
Before this PR:
After:
The other redundant "error:" seems to come from here and I couldn't find a way to remove it by calling SB API only.