build: add node-gyp as a dependency#357
Conversation
Fixes: nodejs#355 Signed-off-by: Matheus Marchini <mmarchini@netflix.com>
|
As a maintainer of node-gyp, depending on a specific version of node-gyp is something I advise against. You should normally use the one that's bundled with node+npm. |
|
Thanks for the feedback @bnoordhuis, I'll probably not merge this then. Any suggestions on #355? Or is it a situation we just can't handle in code, since it's caused by Ubunut/Debian distributing a non-official Node.js package? |
|
#355 seems like a problem of debian or ubuntu's own making. If those distros tracked v8.x LTS like they should have, they'd be at a node-gyp version that's new enough (v5.0.5 vs v3.6.2.) |
|
Closing in favor of #367 |
Pull Request Test Coverage Report for Build ceaaa9333cac9c4a46c36c0c8d4ef286e7086f1b-PR-357Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
Fixes: #355
Signed-off-by: Matheus Marchini mmarchini@netflix.com