build: add missing src/tracing header files#10851
Closed
danbev wants to merge 1 commit intonodejs:masterfrom
Closed
build: add missing src/tracing header files#10851danbev wants to merge 1 commit intonodejs:masterfrom
danbev wants to merge 1 commit intonodejs:masterfrom
Conversation
I noticed that only one header from src/tracing is included in the sources list in node.gyp. Not sure if this is intentional or not so I wanted to bring it up just in case this was overlooked.
bnoordhuis
approved these changes
Jan 17, 2017
cjihrig
approved these changes
Jan 17, 2017
jasnell
approved these changes
Jan 17, 2017
italoacasas
approved these changes
Jan 17, 2017
danbev
added a commit
to danbev/node
that referenced
this pull request
Jan 18, 2017
I noticed that only one header from src/tracing is included in the sources list in node.gyp. Not sure if this is intentional or not so I wanted to bring it up just in case this was overlooked. PR-URL: nodejs#10851 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com>
Contributor
Author
|
Landed in 684590f |
targos
pushed a commit
to targos/node
that referenced
this pull request
Mar 1, 2017
I noticed that only one header from src/tracing is included in the sources list in node.gyp. Not sure if this is intentional or not so I wanted to bring it up just in case this was overlooked. PR-URL: nodejs#10851 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Mar 1, 2017
I noticed that only one header from src/tracing is included in the sources list in node.gyp. Not sure if this is intentional or not so I wanted to bring it up just in case this was overlooked. PR-URL: nodejs#10851 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that only one header from src/tracing is included in the
sources list in node.gyp. Not sure if this is intentional or not so I
wanted to bring it up just in case this was overlooked.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
build