fs: remove unused parameter for encodeRealpathResult#10862
Closed
JacksonTian wants to merge 1 commit intonodejs:masterfrom
Closed
fs: remove unused parameter for encodeRealpathResult#10862JacksonTian wants to merge 1 commit intonodejs:masterfrom
JacksonTian wants to merge 1 commit intonodejs:masterfrom
Conversation
The third parameter `err` is not used anywhere.
addaleax
approved these changes
Jan 18, 2017
Contributor
|
LGTM if CI is green. |
lpinca
approved these changes
Jan 18, 2017
cjihrig
approved these changes
Jan 18, 2017
Contributor
Author
|
Landed in 521767c |
JacksonTian
added a commit
that referenced
this pull request
Jan 18, 2017
The third parameter `err` is not used anywhere. PR-URL: #10862 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Contributor
|
@JacksonTian it looks like this PR was only opened 11 hours ago. We typically require PRs be open for 48-72 hours before landing. |
Contributor
Author
|
Oh, sorry. I don't know the time requirement. What can I do now? |
Contributor
|
Well it got 5 LGTMs. So, if the CI failure is unrelated, I'd say just leave it. |
Contributor
Author
|
Thanks @cjihrig , I will keep slower next time. 😄 |
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 18, 2017
The third parameter `err` is not used anywhere. PR-URL: nodejs#10862 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 23, 2017
The third parameter `err` is not used anywhere. PR-URL: nodejs#10862 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 25, 2017
The third parameter `err` is not used anywhere. PR-URL: nodejs#10862 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 27, 2017
The third parameter `err` is not used anywhere. PR-URL: nodejs#10862 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The third parameter
erris not used anywhere.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
fs