test: wrap callbacks in mustCall() for test-http-agent-destroyed-socket.js #11201
Closed
shubheksha wants to merge 2 commits intonodejs:masterfrom
shubheksha:fix-mustCall-test-http-agent-destroyed-socket
Closed
test: wrap callbacks in mustCall() for test-http-agent-destroyed-socket.js #11201shubheksha wants to merge 2 commits intonodejs:masterfrom shubheksha:fix-mustCall-test-http-agent-destroyed-socket
shubheksha wants to merge 2 commits intonodejs:masterfrom
shubheksha:fix-mustCall-test-http-agent-destroyed-socket
Conversation
Wrap the callbacks which make assertions in common.mustcall() to ensure they are called
Trott
approved these changes
Feb 6, 2017
Member
Trott
left a comment
There was a problem hiding this comment.
LGTM if CI is green. Would prefer to not add the two new console.log() statements if there isn't a super-compelling reason to do so.
| request1.socket.destroy(); | ||
|
|
||
| response.once('close', function() { | ||
| console.log('called'); |
| process.nextTick(common.mustCall(function() { | ||
| // assert that the same socket was not assigned to request2, | ||
| // since it was destroyed. | ||
| console.log('called 2'); |
Member
cjihrig
approved these changes
Feb 6, 2017
Contributor
cjihrig
left a comment
There was a problem hiding this comment.
LGTM, but it looks like one more could be added on line 47 (response.once('close').
Member
@cjihrig That callback does not execute at all when I run the test. (Should it? If so, I think there's a bug.) Perhaps it is there to either handle a race condition or else is platform-dependent? The big comment a few lines above it seems relevant. |
Contributor
|
Yea, that comment does seem relevant. It should be fine to leave line 47 alone since it might not execute. It seems less than ideal to have cases like that in our tests, but that has nothing to do with this PR. |
Member
jasnell
approved these changes
Feb 11, 2017
jasnell
pushed a commit
that referenced
this pull request
Feb 11, 2017
* wrap callbacks in mustCall() * Wrap the callbacks which make assertions in common.mustcall() to ensure they are called PR-URL: #11201 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed in 3d2bd7a |
italoacasas
pushed a commit
that referenced
this pull request
Feb 13, 2017
* wrap callbacks in mustCall() * Wrap the callbacks which make assertions in common.mustcall() to ensure they are called PR-URL: #11201 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 14, 2017
* wrap callbacks in mustCall() * Wrap the callbacks which make assertions in common.mustcall() to ensure they are called PR-URL: nodejs#11201 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
krydos
pushed a commit
to krydos/node
that referenced
this pull request
Feb 25, 2017
* wrap callbacks in mustCall() * Wrap the callbacks which make assertions in common.mustcall() to ensure they are called PR-URL: nodejs#11201 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
needs a backport PR to land in v6 or v4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrap the callbacks which make assertions in common.mustcall() to ensure they are called
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
Tests for http