Closed
Conversation
Indentaiton is off in test-http-server-unconsume-consume.js. The linter isn't complaining, but it probably should be.
bnoordhuis
approved these changes
Feb 7, 2017
Member
bnoordhuis
left a comment
There was a problem hiding this comment.
LGTM, although if the linter isn't complaining...
joyeecheung
approved these changes
Feb 7, 2017
Contributor
Author
|
I'm more curious as to why the linter isn't complaining. I experimented with the file a little bit, and it wasn't complaining at other incorrect indentation levels. cc: @not-an-aardvark |
Contributor
|
It's happening because we have the |
jasnell
approved these changes
Feb 7, 2017
Contributor
|
Minor nit: there's a typo in the commit message. |
Contributor
Author
Contributor
Author
|
Landed in c239581. Thanks. |
cjihrig
added a commit
that referenced
this pull request
Feb 9, 2017
Indentation is off in test-http-server-unconsume-consume.js. The linter isn't complaining, but it probably should be. PR-URL: #11219 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas
pushed a commit
that referenced
this pull request
Feb 13, 2017
Indentation is off in test-http-server-unconsume-consume.js. The linter isn't complaining, but it probably should be. PR-URL: #11219 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 14, 2017
Indentation is off in test-http-server-unconsume-consume.js. The linter isn't complaining, but it probably should be. PR-URL: nodejs#11219 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
krydos
pushed a commit
to krydos/node
that referenced
this pull request
Feb 25, 2017
Indentation is off in test-http-server-unconsume-consume.js. The linter isn't complaining, but it probably should be. PR-URL: nodejs#11219 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Indentaiton is off in
test-http-server-unconsume-consume.js. The linter isn't complaining, but it probably should be.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test