Skip to content

backport: 10805#11562

Closed
mscdex wants to merge 1 commit intonodejs:v7.x-stagingfrom
mscdex:backport-v7-10805
Closed

backport: 10805#11562
mscdex wants to merge 1 commit intonodejs:v7.x-stagingfrom
mscdex:backport-v7-10805

Conversation

@mscdex
Copy link
Contributor

@mscdex mscdex commented Feb 26, 2017 •
edited
Loading

This is a backport of #10805.

CI: https://ci.nodejs.org/job/node-test-pull-request/6590/

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
  • http

@mscdex
http: add new functions to OutgoingMessage
af37092 
PR-URL: nodejs#10805
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
@mscdex mscdex added http Issues or PRs related to the http subsystem. v7.x labels Feb 26, 2017
@nodejs-github-bot nodejs-github-bot added http Issues or PRs related to the http subsystem. v7.x labels Feb 26, 2017
This was referenced Feb 26, 2017
Merged
Merged
@italoacasas
Copy link

italoacasas commented Feb 28, 2017

Landed in staging

italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 28, 2017
@mscdex
http: add new functions to OutgoingMessage
3e8d43d 
PR-URL: nodejs#11562
Backport-of: nodejs#10805
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
@mscdex
Copy link
Contributor Author

mscdex commented Feb 28, 2017 •
edited
Loading

This is a bit offtopic, but I noticed that the PR metadata was changed up a bit. Specifically the PR-URL was changed to point to this PR instead of the original, however all of the Reviewed-By entries are from the original PR, which makes things a bit confusing.

/cc @nodejs/release Is this (using different metadata in backport commit messages) something new we're doing for backport PRs or ?

@mscdex mscdex deleted the backport-v7-10805 branch February 28, 2017 02:58
@italoacasas
Copy link

italoacasas commented Feb 28, 2017

Ups.. that was my bad, I fix the URL part but I forgot completely about the Reviewed-By.

italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 28, 2017
2017-02-28, Version 7.7.0 (Current)
5fd5f19 
Notables changes:
* child_process: spawnSync() exit code now is null when the child is killed via signal (cjihrig)
[nodejs#11288](nodejs#11288)
* http: new functions to access the headers for an outgoing HTTP message (Brian White)
[nodejs#11562](nodejs#11562)
* lib: deprecate node --debug at runtime (Josh Gavant)
[nodejs#11275](nodejs#11275)
* tls: new tls.TLSSocket() supports sec ctx options (Sam Roberts)
[nodejs#11005](nodejs#11005)
* url: adding URL.prototype.toJSON support (Michaël Zasso)
[nodejs#11236](nodejs#11236)
@gibfahn
Copy link
Member

gibfahn commented Feb 28, 2017

I think the plan is to follow #11099 once it lands.

italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 28, 2017
2017-02-28, Version 7.7.0 (Current)
b32ca4f 
Notables changes:

* child_process: spawnSync() exit code now is null when the child is killed via signal (cjihrig)
[nodejs#11288](nodejs#11288)
* http: new functions to access the headers for an outgoing HTTP message (Brian White)
[nodejs#11562](nodejs#11562)
* lib: deprecate node --debug at runtime (Josh Gavant)
[nodejs#11275](nodejs#11275)
* tls: new tls.TLSSocket() supports sec ctx options (Sam Roberts)
[nodejs#11005](nodejs#11005)
* url: adding URL.prototype.toJSON support (Michaël Zasso)
[nodejs#11236](nodejs#11236)
* doc: items in the API documentation may now have changelogs (Anna Henningsen)
[nodejs#11489](nodejs#11489)

PR-URL: nodejs#11553
italoacasas pushed a commit to italoacasas/node that referenced this pull request Mar 1, 2017
2017-02-28, Version 7.7.0 (Current)
a7ffa8d 
Notables changes:

* child_process: spawnSync() exit code now is null when the child is killed via signal (cjihrig)
[nodejs#11288](nodejs#11288)
* http: new functions to access the headers for an outgoing HTTP message (Brian White)
[nodejs#11562](nodejs#11562)
* lib: deprecate node --debug at runtime (Josh Gavant)
[nodejs#11275](nodejs#11275)
* tls: new tls.TLSSocket() supports sec ctx options (Sam Roberts)
[nodejs#11005](nodejs#11005)
* url: adding URL.prototype.toJSON support (Michaël Zasso)
[nodejs#11236](nodejs#11236)
* doc: items in the API documentation may now have changelogs (Anna Henningsen)
[nodejs#11489](nodejs#11489)
* crypto: adding support for OPENSSL_CONF again (Sam Roberts)
[nodejs#11006](nodejs#11006)
* src: adding support for trace-event tracing (misterpoe)
[nodejs#11106](nodejs#11106)

PR-URL: nodejs#11553
italoacasas pushed a commit to italoacasas/node that referenced this pull request Mar 1, 2017
2017-02-28, Version 7.7.0 (Current)
abc13e5 
Notables changes:

* child_process: spawnSync() exit code now is null when the child is killed via signal (cjihrig)
[nodejs#11288](nodejs#11288)
* http: new functions to access the headers for an outgoing HTTP message (Brian White)
[nodejs#11562](nodejs#11562)
* lib: deprecate node --debug at runtime (Josh Gavant)
[nodejs#11275](nodejs#11275)
* tls: new tls.TLSSocket() supports sec ctx options (Sam Roberts)
[nodejs#11005](nodejs#11005)
* url: adding URL.prototype.toJSON support (Michaël Zasso)
[nodejs#11236](nodejs#11236)
* doc: items in the API documentation may now have changelogs (Anna Henningsen)
[nodejs#11489](nodejs#11489)
* crypto: adding support for OPENSSL_CONF again (Sam Roberts)
[nodejs#11006](nodejs#11006)
* src: adding support for trace-event tracing (misterpoe)
[nodejs#11106](nodejs#11106)

PR-URL: nodejs#11553
italoacasas pushed a commit to italoacasas/node that referenced this pull request Mar 1, 2017
2017-02-28, Version 7.7.0 (Current)
15e7028 
Notables changes:

* child_process: spawnSync() exit code now is null when the child is killed via signal (cjihrig)
[nodejs#11288](nodejs#11288)
* http: new functions to access the headers for an outgoing HTTP message (Brian White)
[nodejs#11562](nodejs#11562)
* lib: deprecate node --debug at runtime (Josh Gavant)
[nodejs#11275](nodejs#11275)
* tls: new tls.TLSSocket() supports sec ctx options (Sam Roberts)
[nodejs#11005](nodejs#11005)
* url: adding URL.prototype.toJSON support (Michaël Zasso)
[nodejs#11236](nodejs#11236)
* doc: items in the API documentation may now have changelogs (Anna Henningsen)
[nodejs#11489](nodejs#11489)
* crypto: adding support for OPENSSL_CONF again (Sam Roberts)
[nodejs#11006](nodejs#11006)
* src: adding support for trace-event tracing (misterpoe)
[nodejs#11106](nodejs#11106)

PR-URL: nodejs#11553
imyller added a commit to imyller/meta-nodejs that referenced this pull request Mar 2, 2017
@imyller
2017-02-28, Version 7.7.0 (Current)
8257528 
    Notables changes:

    * child_process: spawnSync() exit code now is null when the child is killed via signal (cjihrig)
    [#11288](nodejs/node#11288)
    * http: new functions to access the headers for an outgoing HTTP message (Brian White)
    [#11562](nodejs/node#11562)
    * lib: deprecate node --debug at runtime (Josh Gavant)
    [#11275](nodejs/node#11275)
    * tls: new tls.TLSSocket() supports sec ctx options (Sam Roberts)
    [#11005](nodejs/node#11005)
    * url: adding URL.prototype.toJSON support (Michaël Zasso)
    [#11236](nodejs/node#11236)
    * doc: items in the API documentation may now have changelogs (Anna Henningsen)
    [#11489](nodejs/node#11489)
    * crypto: adding support for OPENSSL_CONF again (Sam Roberts)
    [#11006](nodejs/node#11006)
    * src: adding support for trace-event tracing (misterpoe)
    [#11106](nodejs/node#11106)

    PR-URL: nodejs/node#11553

Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>
@jasnell
Copy link
Member

jasnell commented Mar 7, 2017

@mscdex ... this will need a backport PR if the intent is to land the new API on v6 or v4 at all

@gibfahn gibfahn mentioned this pull request Apr 24, 2017
Closed
31 tasks
@sam-github sam-github added the semver-minor PRs that contain new features and should be released in the next minor version. label Apr 24, 2017
@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Dec 16, 2017
Closed
@SergeAstapov SergeAstapov mentioned this pull request Oct 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

+1 more reviewer

@italoacasas italoacasas italoacasas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

http Issues or PRs related to the http subsystem. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mscdex @italoacasas @gibfahn @jasnell @sam-github @nodejs-github-bot