doc: some fixes in errors.md#11566
Closed
vsemozhetbyt wants to merge 7 commits intonodejs:masterfrom
vsemozhetbyt:errors.md
Closed
doc: some fixes in errors.md#11566vsemozhetbyt wants to merge 7 commits intonodejs:masterfrom vsemozhetbyt:errors.md
vsemozhetbyt wants to merge 7 commits intonodejs:masterfrom
vsemozhetbyt:errors.md
Conversation
joyeecheung
approved these changes
Feb 26, 2017
cjihrig
approved these changes
Feb 27, 2017
Contributor
cjihrig
left a comment
There was a problem hiding this comment.
LGTM with an optional nit
doc/api/errors.md
Outdated
Contributor
There was a problem hiding this comment.
The actual current error message is shown below, if you feel like changing it:
RangeError: "port" option should be >= 0 and < 65536: -1
Contributor
Author
There was a problem hiding this comment.
So should it be like that?
// throws "RangeError: "port" option should be >= 0 and < 65536: -1"
Contributor
There was a problem hiding this comment.
If you feel like changing it. I don't think it's all that important though.
Contributor
Author
There was a problem hiding this comment.
Done) Maybe it is more reliable with verbatim quoting.
jasnell
approved these changes
Feb 27, 2017
lpinca
approved these changes
Feb 27, 2017
Contributor
Author
|
Could somebody land this, please? |
jasnell
pushed a commit
that referenced
this pull request
Mar 1, 2017
* add semicolons in examples * fix indentation in code example * add spaces in code examples * console.log() -> console.error() * fix level of headings * update comment code example * delete obsolete info and example Fixes: #11558 PR-URL: #11566 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Member
|
Landed in 6aa18aa |
addaleax
pushed a commit
that referenced
this pull request
Mar 5, 2017
* add semicolons in examples * fix indentation in code example * add spaces in code examples * console.log() -> console.error() * fix level of headings * update comment code example * delete obsolete info and example Fixes: #11558 PR-URL: #11566 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Apr 17, 2017
* add semicolons in examples * fix indentation in code example * add spaces in code examples * console.log() -> console.error() * fix level of headings * update comment code example * delete obsolete info and example Fixes: #11558 PR-URL: #11566 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 19, 2017
* add semicolons in examples * fix indentation in code example * add spaces in code examples * console.log() -> console.error() * fix level of headings * update comment code example * delete obsolete info and example Fixes: #11558 PR-URL: #11566 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
andrew749
pushed a commit
to michielbaird/node
that referenced
this pull request
Jul 19, 2017
* add semicolons in examples * fix indentation in code example * add spaces in code examples * console.log() -> console.error() * fix level of headings * update comment code example * delete obsolete info and example Fixes: nodejs/node#11558 PR-URL: nodejs/node#11566 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc, errors
console.log()->console.error()in code examplesargumentsproperty ofReferenceErrorinstance? #11558)