errors: add duplicate symbol checking in E() and increase coverage#11829
Closed
DavidCai1111 wants to merge 1 commit intonodejs:masterfrom
Closed
errors: add duplicate symbol checking in E() and increase coverage#11829DavidCai1111 wants to merge 1 commit intonodejs:masterfrom
DavidCai1111 wants to merge 1 commit intonodejs:masterfrom
Conversation
mscdex
reviewed
Mar 13, 2017
Contributor
There was a problem hiding this comment.
FWIW you could move the arguments to new (indented) lines to avoid new RegExp() and string concatenation:
assert.throws(
() => errors.E('TEST_ERROR_USED_SYMBOL'),
/^AssertionError: Error symbol: TEST_ERROR_USED_SYMBOL was used\.$/);
Contributor
|
The first line of the commit message exceeds 50 characters. |
14348ce to
1e4ab50
Compare
Member
Author
|
@mscdex Thanks for reviewing. Updated, PTAL. |
mscdex
reviewed
Mar 13, 2017
Contributor
There was a problem hiding this comment.
The period should be escaped to avoid matching any character instead of a literal period.
Member
Author
There was a problem hiding this comment.
Oh...Sorry for forgetting that. Updated.
1e4ab50 to
ffbd3a3
Compare
targos
reviewed
Mar 13, 2017
lib/internal/errors.js
Outdated
Member
There was a problem hiding this comment.
maybe "was used before" or "was already used" ?
Member
Author
There was a problem hiding this comment.
@targos Thanks for reviewing. Changed to "was already used", PTAL.
Add duplicate symbol checking in E() to avoid potential confusing result. Increase coverage of internal/errors.
ffbd3a3 to
a907059
Compare
Contributor
jasnell
approved these changes
Mar 13, 2017
cjihrig
approved these changes
Mar 13, 2017
targos
approved these changes
Mar 14, 2017
fhinkel
approved these changes
Mar 15, 2017
Member
|
Thanks. Landed in b5eccc4 |
fhinkel
pushed a commit
that referenced
this pull request
Mar 15, 2017
Add duplicate symbol checking in E() to avoid potential confusing result. Increase coverage of internal/errors. PR-URL: #11829 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Mar 20, 2017
Add duplicate symbol checking in E() to avoid potential confusing result. Increase coverage of internal/errors. PR-URL: nodejs#11829 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
jungx098
pushed a commit
to jungx098/node
that referenced
this pull request
Mar 21, 2017
Add duplicate symbol checking in E() to avoid potential confusing result. Increase coverage of internal/errors. PR-URL: nodejs#11829 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Contributor
|
Doesn't land on v6.x afaict. If it does land somewhere else in the tree lmk |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add duplicate error symbol checking in
E()to avoid potential confusing result.Improve coverage of
internal/errors.js.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
errors