doc: fix confusing reference in net.md#12247
Closed
vsemozhetbyt wants to merge 1 commit intonodejs:masterfrom
vsemozhetbyt:net.md
Closed
doc: fix confusing reference in net.md#12247vsemozhetbyt wants to merge 1 commit intonodejs:masterfrom vsemozhetbyt:net.md
vsemozhetbyt wants to merge 1 commit intonodejs:masterfrom
vsemozhetbyt:net.md
Conversation
Trott
approved these changes
Apr 5, 2017
jasnell
requested changes
Apr 6, 2017
doc/api/net.md
Outdated
Member
There was a problem hiding this comment.
Perhaps...
Following is an example...
cjihrig
approved these changes
Apr 6, 2017
sam-github
suggested changes
Apr 6, 2017
| it starts the connection. | ||
|
|
||
| Here is an example of a client of the previously described echo server: | ||
| Following is an example of a client of the echo server described |
Contributor
There was a problem hiding this comment.
Following -> Here (I'm not sure your text is grammatical, I think it would have to be "Following this is an ...", but just "Here" was fine.
Contributor
Author
There was a problem hiding this comment.
@sam-github This is a wording proposed by @jasnell above. Now I am not sure what to choose)
sam-github
approved these changes
Apr 6, 2017
Contributor
sam-github
left a comment
There was a problem hiding this comment.
OK, sure, it works, lets just fix it.
lpinca
approved these changes
Apr 7, 2017
Contributor
|
@jasnell ping. Does this LGTY after @vsemozhetbyt has updated the PR? |
Member
|
Yes, lgtm!! |
aqrln
approved these changes
Apr 7, 2017
Contributor
Author
|
Landed in 14749f9 |
vsemozhetbyt
added a commit
that referenced
this pull request
Apr 8, 2017
PR-URL: #12247 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Apr 10, 2017
PR-URL: nodejs#12247 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 18, 2017
PR-URL: #12247 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 19, 2017
PR-URL: #12247 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Merged
andrew749
pushed a commit
to michielbaird/node
that referenced
this pull request
Jul 19, 2017
PR-URL: nodejs/node#12247 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc, net
The mentioned echo server is described not previously but in a section below.
I am not sure about rewording, please correct me if needed.