doc: fix missing callback for dns.resolvePtr()#12256
Closed
uppinder wants to merge 1 commit intonodejs:masterfrom
Closed
doc: fix missing callback for dns.resolvePtr()#12256uppinder wants to merge 1 commit intonodejs:masterfrom
uppinder wants to merge 1 commit intonodejs:masterfrom
Conversation
vsemozhetbyt
approved these changes
Apr 6, 2017
Contributor
vsemozhetbyt
left a comment
There was a problem hiding this comment.
Thank you for your contribution. LGTM with a nit: please, keep commit title length within 50 characters (currently 53).
27e4011 to
29084c7
Compare
silverwind
approved these changes
Apr 6, 2017
lpinca
approved these changes
Apr 7, 2017
Contributor
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Apr 10, 2017
PR-URL: nodejs#12256 Fixes: nodejs#12161 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Contributor
|
looks like this api is undocumented in v6.x. Does someone want to backport? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #12161
Checklist
Affected core subsystem(s)
doc