refactor http.get expectedCount with common.mustCall#12668
Closed
weewey wants to merge 2 commits intonodejs:masterfrom
Closed
refactor http.get expectedCount with common.mustCall#12668weewey wants to merge 2 commits intonodejs:masterfrom
weewey wants to merge 2 commits intonodejs:masterfrom
Conversation
Contributor
|
Linter: It seems these variables are not needed anymore. |
aqrln
reviewed
Apr 26, 2017
test/parallel/test-https-strict.js
Outdated
Contributor
There was a problem hiding this comment.
You should probably remove expectResponseCount usages too.
Contributor
Author
|
missed out on removing the variables. I have removed expectResponseCount and responseCount. |
Contributor
hiroppy
approved these changes
Apr 27, 2017
jasnell
approved these changes
Apr 27, 2017
Member
|
Based on email conversation with @weewey, I believe the third commit with changes to |
Contributor
Author
|
yes @Trott I committed the changes in the same branch, as a result the commit was appended. |
Contributor
Author
|
@Trott removed. |
Member
jasnell
pushed a commit
that referenced
this pull request
Apr 28, 2017
PR-URL: #12668 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed in f11d4a1 |
Merged
evanlucas
pushed a commit
that referenced
this pull request
May 1, 2017
PR-URL: #12668 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
May 2, 2017
PR-URL: #12668 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
May 2, 2017
PR-URL: #12668 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor http.get expectedCount with common.mustCall
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)