timer: refactor to use module.exports = {} and ES6 classes#12745
Closed
jasnell wants to merge 2 commits intonodejs:masterfrom
Closed
timer: refactor to use module.exports = {} and ES6 classes#12745jasnell wants to merge 2 commits intonodejs:masterfrom
jasnell wants to merge 2 commits intonodejs:masterfrom
Conversation
Member
|
Also cc @mscdex |
Contributor
|
What are the benchmark results like with Crankshaft (assuming this PR would get backported)? |
Contributor
|
"good luck backporting this" ... I guess? |
Member
Author
|
@mscdex ... no significant variance from current master... (although, I must say that master compared to 7.9 is rather concerning independent of this PR). Backporting shouldn't be a priority at all with this, but the separate |
Member
|
Is changing to ES6 classes backwards compatible? The prototype methods will no longer be enumerable after such a change. |
Member
Author
|
@TimothyGu ... good question. It's likely better to be defensive about it tho. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor to use the more efficient
module.exports = {}pattern and change up the internal objects to use ES6 classes. Benchmarking shows a minor perf improvement under turbo / ignition (not compelling enough by itself, but it's there)./cc @Fishrock123
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
timers