Closed
Conversation
Member
Author
|
Labeled as |
Member
Author
Member
Author
|
Hmmm...Windows fails. A few options:
Thoughts? /cc @jkrems |
Member
Author
|
Added code to skip parts of the test on Windows. CI: https://ci.nodejs.org/job/node-test-pull-request/7767/ Because I hope/expect this to pass CI, I'm going to remove the |
hybrist
approved these changes
May 1, 2017
Contributor
hybrist
left a comment
There was a problem hiding this comment.
I think in the future we should investigate adding make test-node-inspect to our general CI runs. Until then having some smoke tests like this one as part of node's own test suite is definitely valuable.
cjihrig
approved these changes
May 1, 2017
jasnell
approved these changes
May 1, 2017
addaleax
approved these changes
May 3, 2017
Member
|
Linter failure: |
Now that `node debug` is an alias for `node inspect`, it's possible that `node-debug-pid` can run reliably. Modify for current behavior and move from `disabled` to `parallel`.
Member
Author
|
Rebased and adjusted to conform with new lint rule. New CI: https://ci.nodejs.org/job/node-test-pull-request/7842/ |
refack
approved these changes
May 4, 2017
Trott
added a commit
to Trott/io.js
that referenced
this pull request
May 4, 2017
Now that `node debug` is an alias for `node inspect`, it's possible that `node-debug-pid` can run reliably. Modify for current behavior and move from `disabled` to `parallel`. PR-URL: nodejs#12770 Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com>
Member
Author
|
Landed in 4677766 |
anchnk
pushed a commit
to anchnk/node
that referenced
this pull request
May 6, 2017
Now that `node debug` is an alias for `node inspect`, it's possible that `node-debug-pid` can run reliably. Modify for current behavior and move from `disabled` to `parallel`. PR-URL: nodejs#12770 Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that
node debugis an alias fornode inspect, it's possible thatnode-debug-pidcan run reliably. Modify for current behavior and movefrom
disabledtoparallel.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test debugger inspector