(v7.x backport) url: handle windows drive letter in the file state#12880
Closed
watilde wants to merge 1 commit intonodejs:v7.x-stagingfrom
Closed
(v7.x backport) url: handle windows drive letter in the file state#12880watilde wants to merge 1 commit intonodejs:v7.x-stagingfrom
watilde wants to merge 1 commit intonodejs:v7.x-stagingfrom
Conversation
`C|` should not satisfy the condition to not copy the base's path. It also synchronises WPT url test data to verify the update in upstream. PR-URL: nodejs#12808 Refs: whatwg/url#305 Refs: web-platform-tests/wpt#5754 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Member
Author
TimothyGu
approved these changes
May 7, 2017
Member
TimothyGu
left a comment
There was a problem hiding this comment.
LGTM. However, if there was not any merge conflict, the v7.x maintainer should have been able to handle the cherry-picking.
jasnell
approved these changes
May 9, 2017
Member
Author
|
Thanks for reviwing! It has a conflict in the test file. Will put this into v7 staging later. |
Member
Author
|
Landed in 3e80fc8. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #12808 to 7.x:
Checklist
make -j4 testAffected core subsystem(s)
url