Skip to content

dns: synchronize resolve() docs and code#13090

Closed
Trott wants to merge 1 commit intonodejs:masterfrom
Trott:typeerror
Closed

dns: synchronize resolve() docs and code#13090
Trott wants to merge 1 commit intonodejs:masterfrom
Trott:typeerror

Conversation

@Trott
Copy link
Member

@Trott Trott commented May 18, 2017

Synchronize the argument list for dns.resolve() with what's in the
documentation.

Improve the error for a bad rrtype to be a TypeError rather than an
Error.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

dns

@Trott Trott added dns Issues and PRs related to the dns subsystem. dont-land-on-v4.x semver-major PRs that contain breaking changes and should be released in the next major version. labels May 18, 2017
@nodejs-github-bot nodejs-github-bot added the dns Issues and PRs related to the dns subsystem. label May 18, 2017
@Trott
Copy link
Member Author

Trott commented May 20, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/8204/

@Trott
Copy link
Member Author

Trott commented May 20, 2017

Sole test failure is an unrelated known flaky with a fix pending.

@Trott
Copy link
Member Author

Trott commented May 20, 2017

/ping @nodejs/ctc This is ready to land except that it needs another signoff from a CTC member because it is semver-major because of the change to the error message.

@silverwind
Copy link
Contributor

silverwind commented May 28, 2017

Can use a more descriptive commit title? I wouldn't know what this is about if it were in the changelog like it is.

@Trott
Copy link
Member Author

Trott commented May 28, 2017

Can use a more descriptive commit title? I wouldn't know what this is about if it were in the changelog like it is.

I'm open to suggestions that are less than 50 characters. :-D

@silverwind
Copy link
Contributor

silverwind commented May 28, 2017 •
edited
Loading

49 chars: dns: Return TypeError on invalid resolve() input

@Trott
dns: return TypeError on invalid resolve() input
8fcdc9c 
Synchronize the argument list for `dns.resolve()` with what's in the
documentation.

Improve the error for a bad `rrtype` to be a `TypeError` rather than an
`Error`.
@Trott
Copy link
Member Author

Trott commented May 28, 2017

Rebased, updated commit message.

New CI: https://ci.nodejs.org/job/node-test-pull-request/8352/

@joaocgreis
Copy link
Member

joaocgreis commented May 28, 2017

node-test-commit-arm-fanned failed because of a worker issue, here is another run with the same parameters: https://ci.nodejs.org/job/node-test-commit-arm-fanned/9057/

@Trott Trott removed the ctc-review label May 29, 2017
Trott added a commit to Trott/io.js that referenced this pull request May 29, 2017
@Trott
dns: return TypeError on invalid resolve() input
758a17f 
Synchronize the argument list for `dns.resolve()` with what's in the
documentation.

Improve the error for a bad `rrtype` to be a `TypeError` rather than an
`Error`.

PR-URL: nodejs#13090
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@Trott
Copy link
Member Author

Trott commented May 29, 2017

Landed in 758a17f

@Trott Trott closed this May 29, 2017
@Trott
Copy link
Member Author

Trott commented May 29, 2017 •
edited
Loading

It's fine if this has to wait for Node 9.0.0 to be released, but for the record, it is the tiniest of semver majors (change in type from Error to TypeError) and I wouldn't oppose it landing in Node 8.0.0 if it's not too late. Either way is fine with me. /cc @jasnell

@jasnell jasnell mentioned this pull request Oct 30, 2017
Merged
@Trott Trott deleted the typeerror branch January 13, 2022 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

+1 more reviewer

@silverwind silverwind silverwind approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dns Issues and PRs related to the dns subsystem. semver-major PRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Trott @silverwind @joaocgreis @lpinca @targos @cjihrig @nodejs-github-bot