inspector: Allows reentry when paused#13350
Merged
eugeneo merged 1 commit intonodejs:masterfrom Jun 5, 2017
eugeneo:hangs_on_breakpoint
Merged
inspector: Allows reentry when paused#13350eugeneo merged 1 commit intonodejs:masterfrom eugeneo:hangs_on_breakpoint
eugeneo merged 1 commit intonodejs:masterfrom
eugeneo:hangs_on_breakpoint
Conversation
Contributor
Author
|
(I am looking into test failures on different platforms) |
jasnell
approved these changes
Jun 1, 2017
Contributor
Author
This change allows reentering the message dispatch loop when the Node is paused. This is necessary when the pause happened as a result of the message sent by a debug frontend, such as evaluating a function with a breakpoint inside. Fixes: #13320 PR-URL: #13350 Reviewed-By: James M Snell <jasnell@gmail.com>
Contributor
Author
|
Landed as: e6dcc3d |
jasnell
pushed a commit
that referenced
this pull request
Jun 5, 2017
This change allows reentering the message dispatch loop when the Node is paused. This is necessary when the pause happened as a result of the message sent by a debug frontend, such as evaluating a function with a breakpoint inside. Fixes: #13320 PR-URL: #13350 Reviewed-By: James M Snell <jasnell@gmail.com>
Closed
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows reentering the message dispatch loop when the Node is
paused. This is necessary when the pause happened as a result of the
message sent by a debug frontend, such as evaluating a function with a
breakpoint inside.
Fixes: #13320
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
inspector, test