Skip to content

test: increase coverage for internal/module.js#13673

Closed
TamasHodi wants to merge 1 commit intonodejs:masterfrom
TamasHodi:master
Closed

test: increase coverage for internal/module.js#13673
TamasHodi wants to merge 1 commit intonodejs:masterfrom
TamasHodi:master

Conversation

@TamasHodi
Copy link

@TamasHodi TamasHodi commented Jun 14, 2017 •
edited
Loading

Add tests for the stripShebang function.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test internal modules

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jun 14, 2017
@TamasHodi
Copy link
Author

TamasHodi commented Jun 14, 2017

Tests should be fine but i was not able to run them locally.
Is there any way to do that without getting Error: Cannot find module for the required internal module?
I really would like to put the last tick there. :)

@refack
Copy link
Contributor

refack commented Jun 14, 2017

Tests should be fine but i was not able to run them locally.
Is there any way to do that without getting Error: Cannot find module for the required internal module?
I really would like to put the last tick there. :)

Both an answer and a nit: Add // Flags: --expose-internals as the first line in the test file (Example: test/parallel/test-buffer-fill.js). That will tell test.py to call node with the --expose-internals flag. You can also directly test the file with node --expose-internals test/parallel/test-internal-modules.js.

@refack refack added the module Issues and PRs related to the module subsystem. label Jun 14, 2017
@refack
Copy link
Contributor

refack commented Jun 14, 2017

Ohh and P.S. 😉
@TamasHodi thank you very much for the contribution 🥇

@TamasHodi TamasHodi force-pushed the master branch 2 times, most recently from 75caabb to afe49c2 Compare June 14, 2017 13:21
@TamasHodi
Copy link
Author

TamasHodi commented Jun 14, 2017 •
edited
Loading

@refack Thanks for the help! Well, Im going to read the docs next time :P
Btw ive cleaned up the tests so its ready for review.

cjihrig
cjihrig requested changes Jun 14, 2017
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add these changes in a separate file. I don't think we want to lose the things that are currently removed in this PR.

jasnell
jasnell reviewed Jun 14, 2017
View reviewed changes
test/parallel/test-internal-modules.js Outdated
Copy link
Member

@jasnell jasnell Jun 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something like the following would be far more compact (and likely easier to maintain):

[
  ['', ''],
  ['aa', 'aa'],
  ['#!', ''],
  ['#!bin/bash', ''],
  ['#!bin/bash\naa', '\naa']
].forEach((i) => assert.strictEqual(internalModule.stripShebang(i[0]), i[1]));

@TamasHodi
Copy link
Author

TamasHodi commented Jun 14, 2017

@cjihrig I've restored the original test file which was intended to check the availability of the internal modules and moved my refactored tests into a new file.

@refack
Copy link
Contributor

refack commented Jun 14, 2017

CI: https://ci.nodejs.org/job/node-test-commit/10570/

@refack refack self-assigned this Jun 14, 2017
@TamasHodi
Copy link
Author

TamasHodi commented Jun 15, 2017

I've just seen the failing OSX test/build. Did i miss something?
The console output doesn't say that much for me as a newbie. :)

@refack
Copy link
Contributor

refack commented Jun 15, 2017

I've just seen the failing OSX test/build. Did i miss something?
The console output doesn't say that much for me as a newbie. :)

Don't worry, it's unrelated.

@Fishrock123 Fishrock123 mentioned this pull request Jun 16, 2017
Closed
@refack refack removed their assignment Jun 16, 2017
jasnell pushed a commit that referenced this pull request Jun 16, 2017
@jasnell
test: increase coverage for internal/module.js
83ebb6d 
PR-URL: #13673
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Jun 16, 2017

Landed in 83ebb6d

@jasnell jasnell closed this Jun 16, 2017
@refack
Copy link
Contributor

refack commented Jun 16, 2017 •
edited
Loading

@TamasHodi congradulations on landing your first contribution
image
After refresh
image
Many happy returns 😉

addaleax pushed a commit that referenced this pull request Jun 17, 2017
@addaleax
test: increase coverage for internal/module.js
9d94e8c 
PR-URL: #13673
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleax addaleax mentioned this pull request Jun 17, 2017
Merged
addaleax pushed a commit that referenced this pull request Jun 21, 2017
@addaleax
test: increase coverage for internal/module.js
5e59c2d 
PR-URL: #13673
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleax addaleax mentioned this pull request Jun 21, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

+1 more reviewer

@refack refack refack approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

module Issues and PRs related to the module subsystem. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@TamasHodi @refack @jasnell @cjihrig @MylesBorins @nodejs-github-bot