util: ignore invalid format specifiers#13674
Closed
targos wants to merge 2 commits intonodejs:masterfrom
Closed
Conversation
In util.format, if a percent sign without a known type is encountered, just print it instead of silently ignoring it and the next character. Fixes: nodejs#13665
TimothyGu
reviewed
Jun 14, 2017
| // Invalid format specifiers | ||
| assert.strictEqual(util.format('a% b', 'x'), 'a% b x'); | ||
| assert.strictEqual(util.format('percent: %d%, fraction: %d', 10, 0.1), | ||
| 'percent: 10%, fraction: 0.1'); |
Member
There was a problem hiding this comment.
Maybe also test a % at the end of a string?
joyeecheung
approved these changes
Jun 14, 2017
Member
TimothyGu
approved these changes
Jun 14, 2017
cjihrig
approved these changes
Jun 14, 2017
benjamingr
approved these changes
Jun 14, 2017
Member
|
+1 on actual changes. Why did you change your mind from the initial suggestion of |
Member
|
Defensively marking this as a semver-major. While this change is definitely the right thing to do, the change in behavior could potentially break code written to depend on the old behavior (as unlikely as that may be) |
jasnell
approved these changes
Jun 14, 2017
Member
Author
|
This is actually restoring the old behavior (that was lost in #12407) so I would consider this semver-patch. |
Member
|
+1 to semver-patch since the old behavior only changed in 8.x |
Member
|
If there are no objections to landing as semver-patch then I'm good with that |
danbev
approved these changes
Jun 15, 2017
Member
|
/cc @nodejs/ctc ... we have several CTC signoffs already, just want to make sure there are no objections to landing this as a patch. |
Member
|
Landing... |
jasnell
pushed a commit
that referenced
this pull request
Jun 16, 2017
In util.format, if a percent sign without a known type is encountered, just print it instead of silently ignoring it and the next character. PR-URL: #13674 Fixes: #13665 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Member
|
Landed in 00aac57 |
addaleax
pushed a commit
that referenced
this pull request
Jun 17, 2017
In util.format, if a percent sign without a known type is encountered, just print it instead of silently ignoring it and the next character. PR-URL: #13674 Fixes: #13665 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Merged
addaleax
pushed a commit
that referenced
this pull request
Jun 21, 2017
In util.format, if a percent sign without a known type is encountered, just print it instead of silently ignoring it and the next character. PR-URL: #13674 Fixes: #13665 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In util.format, if a percent sign without a known type is encountered,
just print it instead of silently ignoring it and the next character.
Fixes: #13665
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
util