doc: move module-specific "globals" to modules.md#13962
Closed
tniessen wants to merge 2 commits intonodejs:masterfrom
Closed
doc: move module-specific "globals" to modules.md#13962tniessen wants to merge 2 commits intonodejs:masterfrom
tniessen wants to merge 2 commits intonodejs:masterfrom
Conversation
sam-github
reviewed
Jun 28, 2017
doc/api/globals.md
Outdated
|
|
||
| These objects are available in all modules. Some of these objects aren't | ||
| actually in the global scope but in the module scope - this will be noted. | ||
| These objects are available in all modules. The following global-looking |
Contributor
There was a problem hiding this comment.
suggestion:
The following variables may appear to be global but are not. They exist only in the scope of modules, see the module system documentation.
They would show up better in the TOC if each was listed in its original place instead of this bullet list, but with the docs replaced with a explanation and a link to the module system docs.
Member
Author
There was a problem hiding this comment.
That could also reduce problems with old links 👍
jasnell
approved these changes
Jun 29, 2017
lpinca
approved these changes
Jun 29, 2017
Member
Author
|
@sam-github PTAL |
sam-github
approved these changes
Jun 29, 2017
Member
Author
|
Landed in d111319. |
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Jul 3, 2017
PR-URL: nodejs#13962 Fixes: nodejs#13953 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
Contributor
|
This does not land cleanly in LTS. Please feel free to manually backport by following the guide. Please also feel free to replace do-not-land if it is being backported |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #13953
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc