util: delete unused argument 'depth' in lib/util.js#14267
Closed
kadoufall wants to merge 1 commit intonodejs:masterfrom
Closed
util: delete unused argument 'depth' in lib/util.js#14267kadoufall wants to merge 1 commit intonodejs:masterfrom
kadoufall wants to merge 1 commit intonodejs:masterfrom
Conversation
In lib/util.js, Line 1056, there is a 'depth' argument that is unused for 'process.versions[exports.inspect.custom]', so delete it.
Member
gibfahn
approved these changes
Jul 16, 2017
tniessen
approved these changes
Jul 16, 2017
refack
approved these changes
Jul 16, 2017
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Jul 16, 2017
In lib/util.js, Line 1056, there is a 'depth' argument that is unused for 'process.versions[exports.inspect.custom]', so delete it. PR-URL: nodejs#14267 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Refael Ackermann <refack@gmail.com>
Member
|
Green CI, trivial change, four approvals, fast-tracking. Landed in d4402e7 Thanks for the contribution! 🎉 |
Merged
addaleax
pushed a commit
that referenced
this pull request
Jul 18, 2017
In lib/util.js, Line 1056, there is a 'depth' argument that is unused for 'process.versions[exports.inspect.custom]', so delete it. PR-URL: #14267 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Refael Ackermann <refack@gmail.com>
Fishrock123
pushed a commit
that referenced
this pull request
Jul 19, 2017
In lib/util.js, Line 1056, there is a 'depth' argument that is unused for 'process.versions[exports.inspect.custom]', so delete it. PR-URL: #14267 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Refael Ackermann <refack@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
lib/util.js, Line1056, there is adepthargument that is unused forprocess.versions[exports.inspect.custom], so delete it.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
util