test: fix errorMessages regular expressions from crypto-random#14271
Closed
hacke2 wants to merge 1 commit intonodejs:masterfrom
Closed
test: fix errorMessages regular expressions from crypto-random#14271hacke2 wants to merge 1 commit intonodejs:masterfrom
hacke2 wants to merge 1 commit intonodejs:masterfrom
Conversation
test/parallel/test-catpto-random.js contains an object called errorMesssage that contains regular expressions.They are only partially matching regular expressions. Make them match the entire error message.
Contributor
cjihrig
approved these changes
Jul 16, 2017
gibfahn
approved these changes
Jul 16, 2017
tniessen
approved these changes
Jul 16, 2017
Member
|
Ci was green but canceled before the Pi 1 devices finished to help with our backlog. I think this can land. Seems trivial enough and has enough approval that it could be fast-tracked, but I see @tniessen has self-assigned so I'll let them be the judge of that. I'm OK if we choose to fast-track C + L contributions less than I've been doing the last few hours. |
gireeshpunathil
approved these changes
Jul 17, 2017
Member
|
Small change, green CI, 5 approvals, fast-tracking. Landed in 2bbeec7 |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Jul 17, 2017
test/parallel/test-catpto-random.js contains an object called errorMesssage that contains regular expressions.They are only partially matching regular expressions. Make them match the entire error message. PR-URL: nodejs#14271 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Member
|
Thanks for the contribution! 🎉 |
Member
|
We should pay more attention to commit messages... This PR was landed with multiple typos ( |
Merged
addaleax
pushed a commit
that referenced
this pull request
Jul 18, 2017
test/parallel/test-catpto-random.js contains an object called errorMesssage that contains regular expressions.They are only partially matching regular expressions. Make them match the entire error message. PR-URL: #14271 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Fishrock123
pushed a commit
that referenced
this pull request
Jul 19, 2017
test/parallel/test-catpto-random.js contains an object called errorMesssage that contains regular expressions.They are only partially matching regular expressions. Make them match the entire error message. PR-URL: #14271 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test/parallel/test-catpto-random.jscontains an object callederrorMesssage that contains regular expressions.They are only partially
matching regular expressions. Make them match the entire error message.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
crypto