[JSConf CN Code&Learn] Replace the string concatenation with template literals #14284
Closed
HSUCHING wants to merge 2 commits intonodejs:masterfrom
Closed
[JSConf CN Code&Learn] Replace the string concatenation with template literals #14284HSUCHING wants to merge 2 commits intonodejs:masterfrom
HSUCHING wants to merge 2 commits intonodejs:masterfrom
Conversation
Trott
requested changes
Jul 16, 2017
Member
There was a problem hiding this comment.
I think this changes the string. First, \r\n is now just \n. Second, spaces are added at the start of lines (that probably invalidate the http headers).
How about something more like this?:
socket.write(`HTTP/1.1 101 Ok${CRLF}` +
`Connection: Upgrade${CRLF}` +
`Upgrade: Test${CRLF}${CRLF}` +
'head');
gibfahn
approved these changes
Jul 16, 2017
TimothyGu
approved these changes
Jul 16, 2017
Member
TimothyGu
left a comment
There was a problem hiding this comment.
Most other files just use \r\n explicitly. I'd actually prefer that, but LGTM either way.
大部分其它HTTP的测试都直接写\r\n。我觉得那样会更直截了当一些，但是不管怎么说都 LGTM。
Member
|
@Trott PTAL |
tniessen
approved these changes
Jul 16, 2017
gireeshpunathil
approved these changes
Jul 16, 2017
Contributor
Trott
approved these changes
Jul 17, 2017
Member
|
Lone CI failure is unrelated to this change. CI is effectively green. This seems trivial enough that if someone wanted to land it before the 72 hour window, that would be fine IMO. |
jasnell
reviewed
Jul 17, 2017
| 'Upgrade: Test' + CRLF + CRLF + 'head'); | ||
| socket.write(`HTTP/1.1 101 Ok${CRLF}` + | ||
| `Connection: Upgrade${CRLF}` + | ||
| `Upgrade: Test${CRLF}${CRLF}` + |
Member
There was a problem hiding this comment.
the CRLF is a bit pointless here. I'd just replace it with \r\n literals and avoid the template string entirely.
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Jul 26, 2017
PR-URL: nodejs#14284 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Member
|
Landed in 66a6a15. Thanks for the contribution! 🎉 |
addaleax
pushed a commit
that referenced
this pull request
Jul 27, 2017
PR-URL: #14284 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Aug 16, 2017
PR-URL: #14284 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Aug 16, 2017
PR-URL: #14284 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 3, 2017
PR-URL: #14284 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 5, 2017
PR-URL: #14284 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
This was referenced Sep 5, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[JSConf CN Code&Learn]
Replace string concatenation in test /parallel/test-http-upgrade-client2.js with template literals.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
no.
Just update tests.