test: replace string concatenation with template literals#14298
Closed
leizongmin wants to merge 1 commit intonodejs:masterfrom
leizongmin:replace_string_with_template_literals
Closed
test: replace string concatenation with template literals#14298leizongmin wants to merge 1 commit intonodejs:masterfrom leizongmin:replace_string_with_template_literals
leizongmin wants to merge 1 commit intonodejs:masterfrom
leizongmin:replace_string_with_template_literals
Conversation
* test/parallel/test-stdout-close-catch.js
gibfahn
approved these changes
Jul 16, 2017
benjamingr
approved these changes
Jul 16, 2017
Member
benjamingr
left a comment
There was a problem hiding this comment.
I'm +0 on these changes in terms of cruft ratio - but actual code looks fine.
gibfahn
approved these changes
Jul 16, 2017
Contributor
TimothyGu
approved these changes
Jul 16, 2017
Member
|
CI is green! 🎉 |
| const cmd = `${JSON.stringify(process.execPath)} ` + | ||
| `${JSON.stringify(testScript)} | ` + | ||
| `${JSON.stringify(process.execPath)} ` + | ||
| '-pe "process.stdin.on(\'data\' , () => process.exit(1))"'; |
Member
There was a problem hiding this comment.
Is there any scope for improvement here? By combining this line too?
jasnell
approved these changes
Jul 17, 2017
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Jul 23, 2017
* test/parallel/test-stdout-close-catch.js PR-URL: nodejs#14298 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed in a5352d9. |
addaleax
pushed a commit
that referenced
this pull request
Jul 24, 2017
* test/parallel/test-stdout-close-catch.js PR-URL: #14298 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Closed
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Aug 16, 2017
* test/parallel/test-stdout-close-catch.js PR-URL: #14298 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Aug 16, 2017
* test/parallel/test-stdout-close-catch.js PR-URL: #14298 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 3, 2017
* test/parallel/test-stdout-close-catch.js PR-URL: #14298 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 5, 2017
* test/parallel/test-stdout-close-catch.js PR-URL: #14298 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Sep 5, 2017
This was referenced Sep 6, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test: replace string concatenation with template literals