Fixes: https://github.com/nodejs/node/issues/14362#14364
Closed
noviluni wants to merge 1 commit intonodejs:masterfrom
Closed
Fixes: https://github.com/nodejs/node/issues/14362#14364noviluni wants to merge 1 commit intonodejs:masterfrom
noviluni wants to merge 1 commit intonodejs:masterfrom
Conversation
TimothyGu
reviewed
Jul 19, 2017
Member
TimothyGu
left a comment
There was a problem hiding this comment.
Can you please amend the commit message to conform to our commit message guidelines?
6192d69 to
daa24c1
Compare
Author
|
Did it! I wrote my first commit message in that way because of this line: "If your patch fixes an open issue, you can add a reference to it at the end of the log. Use the Fixes: prefix and the full issue URL. " Just my first time... that will not happen again :) |
TimothyGu
approved these changes
Jul 19, 2017
Member
TimothyGu
left a comment
There was a problem hiding this comment.
LGTM, and welcome to Node.js!
cjihrig
approved these changes
Jul 19, 2017
vsemozhetbyt
approved these changes
Jul 19, 2017
Contributor
|
The commit message should include a |
Author
|
Thank you, just updated. |
lpinca
approved these changes
Jul 19, 2017
jasnell
approved these changes
Jul 19, 2017
Member
jasnell
left a comment
There was a problem hiding this comment.
This shouldn't need to wait the normal 48 hours to land
Member
TimothyGu
pushed a commit
that referenced
this pull request
Jul 21, 2017
PR-URL: #14364 Fixes: #14362 Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Jul 22, 2017
PR-URL: #14364 Fixes: #14362 Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Fishrock123
pushed a commit
that referenced
this pull request
Jul 24, 2017
PR-URL: #14364 Fixes: #14362 Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Closed
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Sep 19, 2017
PR-URL: #14364 Fixes: #14362 Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
subsytem: doc
Fixes: #14362
(edited by @vsemozhetbyt: added "Fixes:")