src: return MaybeLocal in AsyncWrap::MakeCallback#14549
Closed
tniessen wants to merge 1 commit intonodejs:masterfrom
Closed
src: return MaybeLocal in AsyncWrap::MakeCallback#14549tniessen wants to merge 1 commit intonodejs:masterfrom
tniessen wants to merge 1 commit intonodejs:masterfrom
Conversation
TimothyGu
approved these changes
Jul 31, 2017
Member
TimothyGu
left a comment
There was a problem hiding this comment.
async-wrap.* LGTM. Other parts rubber-stamp LGTM.
bnoordhuis
approved these changes
Jul 31, 2017
Member
bnoordhuis
left a comment
There was a problem hiding this comment.
LGTM. It would be nice as a follow-up to replace all the non-context calls to Int32Value(), IntegerValue(), etc. with their context overloads.
cjihrig
approved these changes
Jul 31, 2017
jasnell
approved these changes
Jul 31, 2017
addaleax
approved these changes
Jul 31, 2017
Member
Author
|
Landed in 98bae29. CI on master: https://ci.nodejs.org/job/node-test-commit-linuxone/7700/ |
tniessen
added a commit
that referenced
this pull request
Aug 2, 2017
PR-URL: #14549 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Aug 2, 2017
PR-URL: #14549 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MakeCallbackcan return emptyLocals, so it is a good idea to useMaybeLocals here as @trevnorris suggested.I might have missed some uses where the return value is not used, but the code compiles and tests pass, plus these changes should not change the behavior of
MakeCallbackanyway.Partial CI: https://ci.nodejs.org/job/node-test-commit-linuxone/7638/
Linter CI: https://ci.nodejs.org/job/node-test-linter/10833/
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
src