string_decoder: Migrate to use internal/errors#14682
Closed
starkwang wants to merge 1 commit intonodejs:masterfrom
Closed
string_decoder: Migrate to use internal/errors#14682starkwang wants to merge 1 commit intonodejs:masterfrom
starkwang wants to merge 1 commit intonodejs:masterfrom
Conversation
refack
approved these changes
Aug 8, 2017
80 tasks
Contributor
BridgeAR
reviewed
Aug 8, 2017
lib/string_decoder.js
Outdated
Member
There was a problem hiding this comment.
As this is semver-major anyway it could probably be changed to a TypeError
ed34f34 to
660dc96
Compare
targos
approved these changes
Aug 8, 2017
Contributor
|
ping @nodejs/ctc, needs approval |
Member
|
We ship this in Can we hold off until that is ready? I would prefer not having to revert too many commits before releasing 9 if that is not ready. cc @jasnell |
Contributor
|
blocked until we have a modular solution for |
Member
|
At the latest streams wg we decided to unblock this. We would like this (and the equals for Writable, Duplex and Transform) to ship in Node 9. |
jasnell
approved these changes
Sep 13, 2017
BridgeAR
approved these changes
Sep 13, 2017
Member
|
Landed in eb4940e |
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Sep 17, 2017
PR-URL: nodejs/node#14682 Refs: nodejs/node#11273 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Qard
pushed a commit
to Qard/ayo
that referenced
this pull request
Sep 21, 2017
PR-URL: nodejs/node#14682 Refs: nodejs/node#11273 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #11273
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
string_decoder